Bug 172315 - [PATCH] graphics/photopc: Makefile changed, OptionsNG, take maintainership
[PATCH] graphics/photopc: Makefile changed, OptionsNG, take maintainership
Status: Closed FIXED
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s)
Latest
Any Any
: Normal Affects Only Me
Assigned To: jgh
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-10-04 01:30 UTC by nemysis
Modified: 2012-10-04 18:00 UTC (History)
0 users

See Also:


Attachments
photopc-3.07.patch (3.09 KB, patch)
2012-10-04 01:30 UTC, nemysis
no flags Details | Diff
photopc.diff (2.84 KB, patch)
2012-10-04 02:13 UTC, nemysis
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description nemysis 2012-10-04 01:30:11 UTC
Makefile changed

- Trim Makefile headers


- Clean up COMMENT 
+COMMENT=	Control cameras based on Sierra Imaging chipset and compatibles


- Added PLIST_FILES
+PLIST_FILES=	bin/epinfo \


- Rework PORTDOCS
+PORTDOCS=	README protocol.htm usage.htm

- OptionsNG

- Rework post-install target
+	${MKDIR} ${DOCSDIR}
+	${INSTALL_DATA} ${PORTDOCS:S|^|${WRKSRC}/|} ${DOCSDIR}


- Changed pkg-descr


- Take maintainership

Generated and tested manually, tested with port test and with RedPorts (all RELEASES, CLANG), sent with FreeBSD Port Tools 0.99_6 (mode: change, diff: ports)

How-To-Repeat: 
portlint -A
WARN: Makefile: for new port, make $FreeBSD$ tag in comment section empty, to make SVN happy.
0 fatal errors and 1 warning found.

port test: clean

Build log RedPorts

https://redports.org/buildarchive/20121003185238-9618/
Comment 1 jgh freebsd_committer 2012-10-04 01:51:55 UTC
Responsible Changed
From-To: freebsd-ports-bugs->jgh

I'll take it.
Comment 2 nemysis 2012-10-04 02:13:45 UTC
Restored old Makefile Header
Comment 3 dfilter freebsd_committer 2012-10-04 17:52:39 UTC
Author: jgh
Date: Thu Oct  4 16:52:30 2012
New Revision: 305267
URL: http://svn.freebsd.org/changeset/ports/305267

Log:
  - adjust comment and pkg-descr
  - adopt optionsNG
  - pass maintainership to submitter
  
  PR:		172315
  Submitted by:	nemysis@gmx.ch

Modified:
  head/graphics/photopc/Makefile
  head/graphics/photopc/pkg-descr

Modified: head/graphics/photopc/Makefile
==============================================================================
--- head/graphics/photopc/Makefile	Thu Oct  4 16:45:41 2012	(r305266)
+++ head/graphics/photopc/Makefile	Thu Oct  4 16:52:30 2012	(r305267)
@@ -1,29 +1,33 @@
-# New ports collection makefile for:	photopc-1.6
-# Date created:		11 October 1997
-# Whom:			Douglas Carmichael <dcarmich@mcs.com>
+# Created by:			Douglas Carmichael <dcarmich@mcs.com>
 #
 # $FreeBSD$
-#
 
 PORTNAME=	photopc
 PORTVERSION=	3.07
 CATEGORIES=	graphics
 MASTER_SITES=	SF
 
-MAINTAINER=	ports@FreeBSD.org
-COMMENT=	A utility to manage an Epson PhotoPC 500 digital camera
+MAINTAINER=	nemysis@gmx.ch
+COMMENT=	Control cameras based on Sierra Imaging chipset and compatibles
 
 GNU_CONFIGURE=	yes
 MAKE_JOBS_SAFE=	yes
 
+PLIST_FILES=	bin/epinfo \
+		bin/photopc \
+		include/eph_io.h \
+		lib/libeph_io.a
+
 MAN1=		epinfo.1 photopc.1
-PORTDOCS=	protocol.htm usage.htm
-PLIST_FILES=	bin/epinfo bin/photopc include/eph_io.h lib/libeph_io.a
+
+PORTDOCS=	README protocol.htm usage.htm
+
+.include <bsd.port.options.mk>
 
 post-install:
-.if !defined(NOPORTDOCS)
-	@${MKDIR} ${DOCSDIR}
-	${INSTALL_DATA} ${WRKSRC}/*.htm ${DOCSDIR}
+.if ${PORT_OPTIONS:MDOCS}
+	${MKDIR} ${DOCSDIR}
+	${INSTALL_DATA} ${PORTDOCS:S|^|${WRKSRC}/|} ${DOCSDIR}
 .endif
 
 .include <bsd.port.mk>

Modified: head/graphics/photopc/pkg-descr
==============================================================================
--- head/graphics/photopc/pkg-descr	Thu Oct  4 16:45:41 2012	(r305266)
+++ head/graphics/photopc/pkg-descr	Thu Oct  4 16:52:30 2012	(r305267)
@@ -1,20 +1,16 @@
-(From README file):
-/*
-	Copyright (c) 1997 Eugene G. Crosser
+A command-line tool to download picturs and control still digital cameras
+based on Sierra Imaging chipset and compatibles
+(Olympus, Nikon, Epson, Agfa and some others).
 
-	You may do virtually what you wish with this software, as long
-	as the explicit reference to its original author is retained.
+This is a library and a command-line frontend to manipulate digital still
+cameras based on Fujitsu chipset and Sierra Imaging firmware.  The
+program is known to work with Agfa, Epson, Olympus, Sanyo and Nikon (at
+least CoolPix 900, 950 and 8x0 but not CoolPix 600!) cameras.
 
-	THIS SOFTWARE IS PROVIDED AS IS AND COME WITH NO WARRANTY OF ANY
-	KIND, EITHER EXPRESSED OR IMPLIED.  IN NO EVENT WILL THE
-	COPYRIGHT HOLDER BE LIABLE FOR ANY DAMAGES RESULTING FROM THE
-	USE OF THIS SOFTWARE.
-*/
-
-This is a library and a command-line frontend to manipulate an Epson
-PhotoPC digital still camera.  The camera comes with software for
-Windows and for Mac, and no description of the protocol.  With this
-tool, it is managable from a UNIX box.  It is quite probable that the
-program will also work with Olympus Camedia camera.
+The cameras typically come with software for Windows and for Mac, and no
+description of the protocol.  With this tool, they are managable from a
+UNIX box.  Bruce D. Lightner <lightner@lightner.net> has added support
+for Win32 and DOS platforms.  Note that the program does not have any
+GUI, it is plain command-line even on Windows.
 
 WWW: http://photopc.sourceforge.net/
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 4 jgh freebsd_committer 2012-10-04 17:52:48 UTC
State Changed
From-To: open->closed

Committed. Thanks!