Bug 172411 - [PATCH] graphics/netpbm: Not clean reinstall, OptionsNG
Summary: [PATCH] graphics/netpbm: Not clean reinstall, OptionsNG
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Dirk Meyer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-06 21:00 UTC by nemysis
Modified: 2013-02-15 16:09 UTC (History)
1 user (show)

See Also:


Attachments
netpbm-10.35.86.patch (1017 bytes, patch)
2012-10-06 21:00 UTC, nemysis
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description nemysis 2012-10-06 21:00:22 UTC
- OptionsNG

+.include <bsd.port.options.mk>

+.if ${PORT_OPTIONS:MX11}

+.if ${PORT_OPTIONS:MDOCS}


- Not clean reinstall

make reinstall
...
    SRCDIR=/var/tmp/ports/usr/ports/graphics/netpbm/work/netpbm-10.35.86 BUILDDIR=/var/tmp/ports/usr/ports/graphics/netpbm/work/netpbm-10.35.86 install.bin 
    gmake[4]: Entering directory `/var/tmp/ports/usr/ports/graphics/netpbm/work/netpbm-10.35.86/converter/other/fiasco/lib'
    gmake[4]: Nothing to be done for `install.bin'.
    gmake[4]: Leaving directory `/var/tmp/ports/usr/ports/graphics/netpbm/work/netpbm-10.35.86/converter/other/fiasco/lib'
    gmake[3]: Leaving directory `/var/tmp/ports/usr/ports/graphics/netpbm/work/netpbm-10.35.86/converter/other/fiasco'
    cd /usr/local/bin ; \
    ln -s pnmtoplainpnm pnmnoraw
    ln: pnmnoraw: File exists
    gmake[2]: *** [install.bin.local] Error 1
    gmake[2]: Leaving directory `/var/tmp/ports/usr/ports/graphics/netpbm/work/netpbm-10.35.86/converter/other'
    gmake[1]: *** [other/install.bin] Error 2
    gmake[1]: Leaving directory `/var/tmp/ports/usr/ports/graphics/netpbm/work/netpbm-10.35.86/converter'
    gmake: *** [converter/install.bin] Error 2
    *** Error code 2

    Stop in /usr/ports/graphics/netpbm.
    *** Error code 1

    Stop in /usr/ports/graphics/netpbm.


Only this helps for a clean reinstall

cd /usr/local/bin ; rm -f pnmnoraw gemtopbm ppmtojpeg bmptoppm ppmtouil pnmtopnm pnmtofits pnmtotiff pgmslice pnmfile


After this command is clean make reinstall.

===>   Compressing manual pages for netpbm-10.35.86
===>   Running ldconfig
/sbin/ldconfig -m /usr/local/lib
===>   Registering installation for netpbm-10.35.86

Port maintainer (dinoex@FreeBSD.org) is cc'd.

Generated and tested manually, tested with port test, sent with FreeBSD Port Tools 0.99_6 (mode: change, diff: ports)

How-To-Repeat: 
portlint -A
WARN: Makefile: for new port, make $FreeBSD$ tag in comment section empty, to make SVN happy.
WARN: Makefile: LIB_DEPENDS don't specify the ABI version number .4 in tiff.4 unless it is really necessary.
WARN: Makefile: LIB_DEPENDS don't specify the ABI version number .11 in jpeg.11 unless it is really necessary.
WARN: Makefile: LIB_DEPENDS don't specify the ABI version number .1 in jbig.1 unless it is really necessary.
WARN: Makefile: LIB_DEPENDS don't specify the ABI version number .4 in jasper.4 unless it is really necessary.
WARN: Makefile: LIB_DEPENDS don't specify the ABI version number .5 in xml2.5 unless it is really necessary.
0 fatal errors and 6 warnings found.


port test: clean
Comment 1 Edwin Groothuis freebsd_committer 2012-10-06 21:00:34 UTC
Responsible Changed
From-To: freebsd-ports-bugs->dinoex

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer 2013-02-15 14:44:13 UTC
Author: dinoex
Date: Fri Feb 15 14:44:06 2013
New Revision: 312291
URL: http://svnweb.freebsd.org/changeset/ports/312291

Log:
  - cleanup options
  PR:		172411
  Submitted by:	nemysis

Modified:
  head/graphics/netpbm/Makefile

Modified: head/graphics/netpbm/Makefile
==============================================================================
--- head/graphics/netpbm/Makefile	Fri Feb 15 14:21:45 2013	(r312290)
+++ head/graphics/netpbm/Makefile	Fri Feb 15 14:44:06 2013	(r312291)
@@ -31,7 +31,9 @@ USE_LDCONFIG=	yes
 
 MAN1=		netpbm.1
 
-.if defined(WITH_X11)
+.include <bsd.port.options.mk>
+
+.if ${PORT_OPTIONS:MX11}
 USE_XORG=	x11
 MAKE_ENV+=	WITH_X11="${WITH_X11}"
 PLIST_SUB+=	X11=''
@@ -67,8 +69,8 @@ post-install:
 	@${REINPLACE_CMD} -e 's|doc/USERDOC|${DOCSDIR}/USERDOC|g' \
 		${WRKSRC}/doc/netpbm.1
 	${INSTALL_MAN} ${WRKSRC}/doc/netpbm.1 ${MANPREFIX}/man/man1
-.if !defined(NOPORTDOCS)
-	@${MKDIR} ${DOCSDIR}
+.if ${PORT_OPTIONS:MDOCS}
+	${MKDIR} ${DOCSDIR}
 	${INSTALL_DATA} ${WRKSRC}/doc/USERDOC ${DOCSDIR}/
 .endif
 
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 3 Dirk Meyer freebsd_committer 2013-02-15 16:09:43 UTC
State Changed
From-To: open->closed

committed, thanks.