Bug 172534 - [patch] FICL - correct handling of bare comment lines
Summary: [patch] FICL - correct handling of bare comment lines
Status: Open
Alias: None
Product: Base System
Classification: Unclassified
Component: bin (show other bugs)
Version: 8.3-STABLE
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-bugs mailing list
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-09 23:30 UTC by Peter Jeremy
Modified: 2017-12-31 22:29 UTC (History)
1 user (show)

See Also:


Attachments
file.diff (486 bytes, patch)
2012-10-09 23:30 UTC, Peter Jeremy
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Jeremy 2012-10-09 23:30:16 UTC
	Various forth files in sys/boot/ficl/softwords/ are converted
	to a C string code for embedding into the FICL binary using an
	awk script softcore.awk.  This script fails to strip out
	comments that consist of a sole backslash.  Whilst this isn't
	a problem for the standard set of SOFTWORDS, the
	not-normally-included oo.fr contains comments in the
	array-init definition that cause softcore.awk to emit the
	string "\ " - which gcc rejects.

Fix: According to diff on stable-8, the following patch does not
	result in any change to the default softcore.c and only
	removes the two "\ " lines when the optional object-oriented
	words are added.
How-To-Repeat: 	# cd /sys/boot/ficl
	uncomment the line 'SOFTWORDS+= oo.fr classes.fr' in Makefile
	# make testmain
	fails with:
(cd /home/peter/forth/boot/ficl/softwords; cat softcore.fr jhlocal.fr marker.fr freebsd.fr ficllocal.fr  ifbrack.fr oo.fr classes.fr  | awk -f softcore.awk -v datestamp="`LC_ALL=C date`") > softcore.c
cc -O2 -pipe  -ffreestanding -mpreferred-stack-boundary=2 -mno-mmx -mno-3dnow -mno-sse -mno-sse2 -std=gnu99   -m32 -march=i386 -I. -I/home/peter/forth/boot/ficl -I/home/peter/forth/boot/ficl/i386  -I/home/peter/forth/boot/ficl/../common -c softcore.c
softcore.c:917:5: warning: unknown escape sequence: '\040'
softcore.c:917:5: warning: unknown escape sequence: '\040'
Comment 1 Eitan Adler freebsd_committer freebsd_triage 2012-10-18 23:57:56 UTC
Responsible Changed
From-To: freebsd-bugs->eadler

I'll take it.
Comment 2 Eitan Adler freebsd_committer freebsd_triage 2012-11-08 20:54:46 UTC
Responsible Changed
From-To: eadler->freebsd-bugs

I won't be dealing with this PR for some time, so give it back to the 
pool
Comment 3 Eitan Adler freebsd_committer freebsd_triage 2017-12-31 07:59:52 UTC
For bugs matching the following criteria:

Status: In Progress Changed: (is less than) 2014-06-01

Reset to default assignee and clear in-progress tags.

Mail being skipped