Upgrade to from 0.8 to 0.10; add OptionsNG for DOCS and EXAMPLES.
Fix: Please see the attached patch.
Note: files/Makefile, files/blink2.pde and files/patch-Arduino.mk are all obsolete and should be removed.
Patch attached with submission follows:
I'll take it.
Committed, thanks. You might want to run portlint in your next patches,
as there's some low-hanging fruit there that could be fixed.
On 10/21/12 04:15, rakuco@FreeBSD.org wrote:
> Committed, thanks. You might want to run portlint in your next patches,
> as there's some low-hanging fruit there that could be fixed.
I did run portlint and didn't see anything that can be fixed.
> WARN: Makefile: possible use of absolute pathname
This path is used to patch a hardcode path in bin/ard-parse-boards; this
portlint test is a bit simplistic.
This could be a patch except we don't know what PREFIX will be in advance.
> WARN: Makefile: only one MASTER_SITE configured. Consider adding
> additional mirrors.
It'd be nice if there were mirrors for this but there currently are not.
> WARN: Makefile: using hyphen in PORTNAME. consider using PKGNAMEPREFIX
> and/or PKGNAMESUFFIX.
The package is actually named "arduino-mk" so I believe that's what
PORTNAME should be set to, portlint not withstanding.
> WARN: Makefile: dependency to gmake listed in RUN_DEPENDS. consider
> using USE_GMAKE.
This is documented in the Makefile:
# gmake is needed to use the port, not to build it
USE_GMAKE means "The port requires gmake to build" but not only is gmake
not needed to build the port, there's nothing to build and so NO_BUILD
is set. Maybe portlint should suppress this warning when NO_BUILD is
Craig Leres <firstname.lastname@example.org> writes:
>> Committed, thanks. You might want to run portlint in your next patches,
>> as there's some low-hanging fruit there that could be fixed.
> I did run portlint and didn't see anything that can be fixed.
Right, it looks like you've got it all covered :-) Sorry for the false