Bug 173002 - [net] [patch] data type size problem in if_spppsubr.c
Summary: [net] [patch] data type size problem in if_spppsubr.c
Status: Open
Alias: None
Product: Base System
Classification: Unclassified
Component: kern (show other bugs)
Version: Unspecified
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-net (Nobody)
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2012-10-23 20:10 UTC by Jens Wiatrowski
Modified: 2019-01-26 12:48 UTC (History)
1 user (show)

See Also:


Attachments
file.diff (504 bytes, patch)
2012-10-23 20:10 UTC, Jens Wiatrowski
no flags Details | Diff
if_spppsubr.c.patch (365 bytes, patch)
2012-10-23 23:08 UTC, Eitan Adler
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jens Wiatrowski 2012-10-23 20:10:00 UTC
Because cmd in struct spppreq (/usr/include/net/if_sppp.h) is an int,
fuword32() should be used instead of fuword() in sys/net/if_spppsubr.c, line 5133, I think.

Fix: Apply the patch I've appended.
Or change the type of cmd in struct spppreq to unsigned long.

Patch attached with submission follows:
How-To-Repeat: Use /sbin/spppcontrol on a 64bit machine.
Comment 1 Eitan Adler freebsd_committer freebsd_triage 2012-10-23 23:08:15 UTC
---------- Forwarded message ----------
From: Jens Wiatrowski <wiatro@gmx.net>
Date: 23 October 2012 16:40
Subject: Re: Re: kern/173002: data type size problem in if_spppsubr.c
To: Eitan Adler <lists@eitanadler.com>


        Hello Eitan,

>
>please send the output of "diff -u" (unified diff) - this makes it
>more likely someone will look at the patch
>
Attached.

        Regards

                Jens


-- 
Eitan Adler
Comment 2 Mark Linimon freebsd_committer freebsd_triage 2012-10-30 15:10:40 UTC
Responsible Changed
From-To: freebsd-bugs->freebsd-net

Over to maintainer(s).
Comment 3 Eitan Adler freebsd_committer freebsd_triage 2017-12-31 08:00:40 UTC
For bugs matching the following criteria:

Status: In Progress Changed: (is less than) 2014-06-01

Reset to default assignee and clear in-progress tags.

Mail being skipped
Comment 4 Andriy Voskoboinyk freebsd_committer 2019-01-26 12:48:50 UTC
I have no clue which type is right here; return PR to the net@