Bug 173295 - [patch] graphics/tesseract incorrect distinfo
Summary: [patch] graphics/tesseract incorrect distinfo
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Brendan Fabeny
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-02 12:40 UTC by Oliver Heesakkers
Modified: 2012-11-03 12:20 UTC (History)
0 users

See Also:


Attachments
file.diff (729 bytes, patch)
2012-11-02 12:40 UTC, Oliver Heesakkers
no flags Details | Diff
patch.txt (921 bytes, text/x-patch; charset="UTF-8")
2012-11-02 12:51 UTC, Oliver Heesakkers
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Oliver Heesakkers 2012-11-02 12:40:01 UTC
The port graphics/tesseract fails to download the new distfile for version 3.02.02 as the size on the server mismatches the size in distinfo

`make makesum` actually failed for me as a result of the documentation distfile being in that separate .if/.endif construct which tests for the use of make makesum (sha256: tesseract/tesseract-ocr-3.02.02-doc-html.tar.gz: No such file or directory)

I temporarily copied the DISTFILE+= line to line 13 which made `make makesum` complete succesfully.

Fix: The attached patch provides SIZEs and SHA256 checksums as they are currently offered on tesseracts project page.

Patch attached with submission follows:
Comment 1 Edwin Groothuis freebsd_committer 2012-11-02 12:40:32 UTC
Responsible Changed
From-To: freebsd-ports-bugs->bf

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Oliver Heesakkers 2012-11-02 12:51:23 UTC
Oops, wrong patch, here is the right one.
Comment 3 b. f. 2012-11-03 06:55:38 UTC
Thanks for your attention.  However, I fixed this in:

http://svnweb.freebsd.org/ports?view=revision&revision=306843

before the PR was filed. (Before going to the trouble of submitting a
PR, it helps to look at the main repository -- not the mirrors,
because changes take some time to propagate to them -- to check that
no changes have already been made to the port.)  The problem was that
the upstream maintainers decided to silently change the distfiles
(mostly to include build infrastructure regenerated with newer
autotools, and other changes of little consequence) after the initial
release without renaming them, which is discouraging to packagers.

I'm not quite sure what sequence of events led you to conclude that
the makesum target was broken: it has always worked for me.

b.
Comment 4 Brendan Fabeny freebsd_committer 2012-11-03 07:08:50 UTC
State Changed
From-To: open->closed

Fixed in r306843.
Comment 5 Oliver Heesakkers 2012-11-03 12:10:59 UTC
Op za 03 nov 2012 02:55:38 schreef b. f.:
> Thanks for your attention.  However, I fixed this in:
> 
> http://svnweb.freebsd.org/ports?view=revision&revision=306843

Yeah, I probably just missed that. I figured something like a reroll had 
happened.

> I'm not quite sure what sequence of events led you to conclude that
> the makesum target was broken: it has always worked for me.

I always rely on makesum to fetch the new distfiles, but for the doc-file in 
your Makefile the fetching part is skipped and it immediately tries to access 
the distfile, which in my use case doesn't exist at that point.

When you download the distfiles manually, makesum will complete correctly.