- Update to 4.0.1 - Complies with PREFIX - Findlib name is set back to `camlimages' instead of `images' - No documentation Documentation is available on line but not ``distributed'' as such, so I decided to left it out. Fix: Patch attached with submission follows:
Note: in order to be applied from within graphcis/ocaml-images the patch must be stripped with --strip=2.
Responsible Changed From-To: freebsd-ports-bugs->bf I'll take it.
There's at least three problems with this port. 1) patch-src_pngread.c should be removed completely. 2) patch-src_pngwrite.c should be removed completely. 3) There is a build dependency on devel/omake that is not documented For the first 2, src/pngread.c and src/pngwrite.c are already patched, so these packages just dump all hunks to a rejects file. I have to get devel/omake building before I can continue. Hopefully there are no more problems with graphics/ocaml-images. John
I'm not sure what happened because the two png patches *were* good and they were necessary. The dependency on omake is still valid though. Speaking of which, I basically imported that from pkgsrc because the current version didn't build with ocaml 4.00 and the 9.8.6rc1 needed something like 26 patches! Here's the final version of devel/omake that got imported into dports: https://github.com/jrmarino/DPorts/commit/24e135f529690389cd5c215c6be0f8fbb7fbfc20 And the final version of ocamlimages that got imported into dports: https://github.com/jrmarino/DPorts/commit/bd7b5e5463d7d32c41d1506fd6dc8fa0f0ff1283 Permanent locations of those two are: https://github.com/jrmarino/DPorts/tree/master/devel/omake https://github.com/jrmarino/DPorts/tree/master/graphics/ocaml-images John
Hi John, thank you for your feedback, John Marino wrote: > There's at least three problems with this port. > > 1) patch-src_pngread.c should be removed completely. > 2) patch-src_pngwrite.c should be removed completely. > 3) There is a build dependency on devel/omake that is not documented > > For the first 2, src/pngread.c and src/pngwrite.c are already patched, > so these packages just dump all hunks to a rejects file. I did not see this: In pngread.c I have /* error handling */ if (setjmp(png_ptr->jmpbuf)) { /* Free all of the memory associated with the png_ptr and info_ptr */ and my patch file says something like @@ -243,7 +243,7 @@ } /* error handling */ - if (setjmp(png_ptr->jmpbuf)) { + if (setjmp(png_jmpbuf(png_ptr))) { /* Free all of the memory associated with the png_ptr and info_ptr */ png_destroy_read_struct(&png_ptr, &info_ptr, (png_infopp)NULL); fclose(fp); What makes you think the source is already patched? > I have to get devel/omake building before I can continue. Hopefully > there are no more problems with graphics/ocaml-images. I will add the required dependency! Best regards, Michael
On 3/28/2013 07:57, Michael Grünewald wrote: > > What makes you think the source is already patched? > >> I have to get devel/omake building before I can continue. Hopefully >> there are no more problems with graphics/ocaml-images. > > I will add the required dependency! Hi Michael, I submitted a follow-up to that post that answers your question. http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/173453 Summary: That statement was a mistake, the source is not already patched. Please read the complete follow-up though! John
Responsible Changed From-To: bf->marino I'll take it.
Hi Michael, As you may have noticed, I pulled in Ocaml 4.00.1 from DPorts. I knew it was not the very latest version, nor is the port staged. Therefore I'm leaving this PR open and I just took over responsibility for it. What I would like you to do is check out the latest version of lang/ocaml (4.00.1) and update to 4.0.1 or whatever is now the latest, and at the same time provide stage support. And tweak whatever else you think is necessary -- you are the maintainer after all. I got the ball rolling for you again, and now it's back in your court. John
Hi Michael, I just realized that this PR is for ocaml-images, which is already at 4.0.1. I thought this was a duplicate PR for lang/ocaml with same version of 4.0.1. I will close this, but please submit a new PR for the update of lang/ocaml 4.00.1. I just checked and 4.00.1 seems to be the latest (I thought there was a newer version), but this port still needs to be staged. There may be other fixes that got lost when I closed the related PR. Thanks, John
State Changed From-To: open->closed port has been updated to latest, but not directly from this PR
Hi John, thank you for your feedback! John Marino wrote: > I just realized that this PR is for ocaml-images, which is already at > 4.0.1. I thought this was a duplicate PR for lang/ocaml with same > version of 4.0.1. > > I will close this, but please submit a new PR for the update of > lang/ocaml 4.00.1. I just checked and 4.00.1 seems to be the latest (I > thought there was a newer version), but this port still needs to be staged. I will go to these things by next Sunday I will update the PRs to keep track of my progress. Best regards, Michael