Patch patch-atacam is no longer need in smartmontools 6.0. Morever beacuse of this patch smartctl no longer works on systems with LSI Megaraid and mfip kernel module: https://sourceforge.net/apps/trac/smartmontools/ticket/247 Fix: To fix smartctl issue patch files/patch-atacam should be removed.
Maintainer of sysutils/smartmontools, Please note that PR ports/173495 has just been submitted. If it contains a patch for an upgrade, an enhancement or a bug fix you agree on, reply to this email stating that you approve the patch and a committer will take care of it. The full text of the PR can be found at: http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/173495 -- Edwin Groothuis via the GNATS Auto Assign Tool edwin@FreeBSD.org
State Changed From-To: open->feedback Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Responsible Changed From-To: freebsd-ports-bugs->rm I will take it.
Please close this PR. This patch is not useless. Problem with mfip is known and is fixed in upcoming 6.1. I don`t have time to backport this to the 6.0 and i don`t feel that this bug is critical.
On 11/09/12 14:35, Alex Samorukov wrote: > Please close this PR. This patch is not useless. Problem with mfip is known and > is fixed in upcoming 6.1. I don`t have time to backport this to the 6.0 and i > don`t feel that this bug is critical. In which cases this patch still need? In commit log: http://svnweb.freebsd.org/ports?view=revision&revision=299659 stated, this this patch fix scanning of ada disks on ata busses But in 6.0 ada disks on ata busses (via ATA_CAM wrapper, as I understand), properly detected by smartd without this patch. -- Anton Yuzhaninov
On 11/09/2012 11:39 AM, Anton Yuzhaninov wrote: > On 11/09/12 14:35, Alex Samorukov wrote: >> Please close this PR. This patch is not useless. Problem with mfip is >> known and >> is fixed in upcoming 6.1. I don`t have time to backport this to the >> 6.0 and i >> don`t feel that this bug is critical. > > In which cases this patch still need? > > In commit log: > http://svnweb.freebsd.org/ports?view=revision&revision=299659 > stated, this this patch fix scanning of ada disks on ata busses > > But in 6.0 ada disks on ata busses (via ATA_CAM wrapper, as I > understand), properly detected by smartd without this patch. > AFAIR this patch was for different purpose - to avoid passX as default device name. Please check smartmontools SVN and tell if it works for you, it has reworked patch.
On 11/09/12 14:44, Alex Samorukov wrote: >> > AFAIR this patch was for different purpose - to avoid passX as default device > name. Please check smartmontools SVN and tell if it works for you, it has > reworked patch. In SVN version smartctl works for me (on /dev/passX from mfip). -- Anton Yuzhaninov
Responsible Changed From-To: rm->freebsd-ports-bugs Back to pool. Didn't got maintainer's reponse.
> Back to pool. Didn't got maintainer's reponse. I already responded and asked to close this PR.
State Changed From-To: feedback->closed Closing by maintainer's request. Will be fixed in next release.