Bug 173556 - [ patch ] no option to compile crypto support in devel/apr1
Summary: [ patch ] no option to compile crypto support in devel/apr1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-apache (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-11 14:40 UTC by Dan Lukes
Modified: 2012-12-12 20:19 UTC (History)
0 users

See Also:

Attachments
file.diff (913 bytes, patch)
2012-11-11 14:40 UTC, Dan Lukes 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dan Lukes 2012-11-11 14:40:00 UTC 
	Althougth apr1 has optional crypto support (with default off), 
	there is OPTION to compile it
	The APU's crypto support will be required for future www/apache24 port  
        (is required during configuration of Apache's mod_session_crypto module)

Fix: It's simple change of port's Makefile:

	OPTION named CRYPTO added, default is off (e.g. no change against current behavior)
How-To-Repeat: 	N/A
Comment 1 Tilman Keskinoz freebsd_committer freebsd_triage 2012-11-21 16:55:12 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->apache

over to maintainergroup
Comment 2 Olli Hauer freebsd_committer freebsd_triage 2012-11-21 17:53:38 UTC 
State Changed
From-To: open->analyzed

Hi Dan, 

it is on my roadmap, but with an update to apr-util-1.5.1 
which contains bsd related fixes for crypto. 
http://www.apache.org/dist/apr/CHANGES-APR-UTIL-1.5 

Anyway if you are using the option crypto you need an update 
for pkg-plist see http://people.freebsd.org/~ohauer/diffs/apr1-crypto.diff 

-- 
Regards, 
olli
Comment 3 Dan Lukes 2012-11-22 19:03:04 UTC 
On 11/21/12 18:59, ohauer@FreeBSD.org:
> it is on my roadmap, but with an update to apr-util-1.5.1
> which contains bsd related fixes for crypto.
> http://www.apache.org/dist/apr/CHANGES-APR-UTIL-1.5

I have nothing against immediate update to 1.5.1 ;-)

> if you are using the option crypto you need an update

True, I missed it in my patch.

> see http://people.freebsd.org/~ohauer/diffs/apr1-crypto.diff

It look good, let's go on.

Thank you for your cooperation.

Dan
Comment 4 Olli Hauer freebsd_committer freebsd_triage 2012-11-22 22:14:58 UTC 
> It look good, let's go on.
> Thank you for your cooperation.

Please note we are in feature freeze, so unless 9.1 is released there
in no chance to commit the diff, specialty since I want to enable
crypto per default.

For apr-util-1.5.x we have to do an expression run, this mean test
builds for every port (at last every port which depends direct or
indirect on apr on several cpu archs and releases).

So it can take a while.

--
Regards,
olli
Comment 5 Dan Lukes 2012-11-22 22:29:57 UTC 
On 11/22/12 23:14, Olli Hauer:
> we are in feature freeze

I'm familiar with it.

As crypto support in apr-1 is prerequisite for future www/apache24 which 
is not on the way (as far as I know) it's not urgent change in any way.

Thank you for your support.

Dan
Comment 6 Olli Hauer freebsd_committer freebsd_triage 2012-12-12 20:16:42 UTC 
State Changed
From-To: analyzed->closed

I just added the crypto framework to apr.