Bug 173573 - [patch] editors/semi does not build if WRKDIRPREFIX is set
Summary: [patch] editors/semi does not build if WRKDIRPREFIX is set
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: MANTANI Nobutaka
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-12 04:30 UTC by Joel Ray Holveck
Modified: 2013-01-26 17:20 UTC (History)
0 users

See Also:


Attachments
file.diff (1.35 KB, patch)
2012-11-12 04:30 UTC, Joel Ray Holveck
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joel Ray Holveck 2012-11-12 04:30:00 UTC
If WRKDIRPREFIX is set, editors/semi will not build.

In several places, the port's Makefile will run "${MAKE} some-target"
where some-target is defined in the Makefile.  When these commands are
run, the current directory will be OBJDIR (e.g.,
/path/to/objs/usr/ports/editors/semi).  Since there's no Makefile in
there, the submake will fail.

Fix: Call ${MAKE} with the -C flag.  Patch follows.
How-To-Repeat: mkdir -p /usr/obj
echo WRKDIRPREFIX=/usr/obj >> /etc/make.conf
cd /usr/ports/editors/semi
make
Comment 1 Edwin Groothuis freebsd_committer 2012-11-12 04:30:36 UTC
Responsible Changed
From-To: freebsd-ports-bugs->nobutaka

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer 2013-01-26 17:19:16 UTC
Author: nobutaka
Date: Sat Jan 26 17:19:03 2013
New Revision: 311035
URL: http://svnweb.freebsd.org/changeset/ports/311035

Log:
  Fix build error when WRKDIRPREFIX is set.
  
  PR:		ports/173573
  Submitted by:	Joel Ray Holveck <joelh@piquan.org>

Modified:
  head/editors/semi/Makefile

Modified: head/editors/semi/Makefile
==============================================================================
--- head/editors/semi/Makefile	Sat Jan 26 17:08:42 2013	(r311034)
+++ head/editors/semi/Makefile	Sat Jan 26 17:19:03 2013	(r311035)
@@ -76,35 +76,35 @@ MAKEINFO_EMACS_FLAGS=	-e texinfo-format-
 
 pre-build:
 .if defined(EMACS_PACKAGESDIR) && defined(XEMACS_PKGNAME)
-	@${MAKE} pkg-el-copy
+	@${MAKE} -C ${.CURDIR} pkg-el-copy
 .endif
 
 post-build:
 .if defined(BUILD_INFO_BY_EMACS) && (${BUILD_INFO_BY_EMACS} == "YES")
-	@${MAKE} info-build-by-emacs
+	@${MAKE} -C ${.CURDIR} info-build-by-emacs
 .else
-	@${MAKE} info-build
+	@${MAKE} -C ${.CURDIR} info-build
 .endif
 
 pre-install:
 .if defined(EMACS_PACKAGESDIR) && defined(EMACS_PACKAGES_SUBDIRS)
-	@${MAKE} mkdir-site-packages
+	@${MAKE} -C ${.CURDIR} mkdir-site-packages
 .endif
 .if defined(EMACS_PACKAGESDIR) && defined(XEMACS_PKGNAME)
-	@${MAKE} pkg-el-install
+	@${MAKE} -C ${.CURDIR} pkg-el-install
 .endif
 
 post-install:
 	@${MKDIR} ${LOCALBASE}/share/semi
 	@${TOUCH} ${LOCALBASE}/share/semi/${SEMI_COOKIE}
 .if defined(EMACS_PACKAGESDIR) && defined(MANIFEST)
-	@${MAKE} info-package-install
-	@${MAKE} manifest-install
+	@${MAKE} -C ${.CURDIR} info-package-install
+	@${MAKE} -C ${.CURDIR} manifest-install
 .else
-	@${MAKE} info-install
+	@${MAKE} -C ${.CURDIR} info-install
 .endif
 .if ${PORT_OPTIONS:MDOCS}
-	@${MAKE} doc-install
+	@${MAKE} -C ${.CURDIR} doc-install
 .endif
 
 ###############################################################################
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 3 MANTANI Nobutaka freebsd_committer 2013-01-26 17:19:18 UTC
State Changed
From-To: open->closed

Committed, thanks!