Dimitry, Thanks! I was already working on updating the wesnoth port so I will include this. Rusty Nejdl
- Fix plist for WITHOUT_SERVER case (http://people.freebsd.org/~amdmi3/wesnoth-noserver-1.10.4.log) - Remove unneeded apostrophe escaping Port maintainer (rnejdl@ringofsaturn.com) is cc'd. Generated with FreeBSD Port Tools 0.99_6 (mode: change, diff: ports)
Maintainer of games/wesnoth, Please note that PR ports/174139 has just been submitted. If it contains a patch for an upgrade, an enhancement or a bug fix you agree on, reply to this email stating that you approve the patch and a committer will take care of it. The full text of the PR can be found at: http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/174139 -- Edwin Groothuis via the GNATS Auto Assign Tool edwin@FreeBSD.org
State Changed From-To: open->feedback Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
On 2012-12-05 02:30, Edwin Groothuis wrote: > Maintainer of games/wesnoth, > > Please note that PR ports/174139 has just been submitted. > > If it contains a patch for an upgrade, an enhancement or a bug fix > you agree on, reply to this email stating that you approve the patch > and a committer will take care of it. > > The full text of the PR can be found at: > http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/174139 Please find attached a diff that includes this fix as well as updating to 1.10.5 (stable). Rusty Nejdl
* Rusty Nejdl (rnejdl@ringofsaturn.com) wrote: > > Maintainer of games/wesnoth, > > > > Please note that PR ports/174139 has just been submitted. > > > > If it contains a patch for an upgrade, an enhancement or a bug fix > > you agree on, reply to this email stating that you approve the patch > > and a committer will take care of it. > > > > The full text of the PR can be found at: > > http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/174139 > > Please find attached a diff that includes this fix as well as updating > to 1.10.5 (stable). Looks good, currently testing in a tinderbox. Should I commit it afterwards? -- Dmitry Marakasov . 55B5 0596 FF1E 8D84 5F56 9510 D35A 80DD F9D2 F77D amdmi3@amdmi3.ru ..: jabber: amdmi3@jabber.ru http://www.amdmi3.ru
On 2012-12-05 08:25, Dmitry Marakasov wrote: > * Rusty Nejdl (rnejdl@ringofsaturn.com) wrote: > >>> Maintainer of games/wesnoth, >>> >>> Please note that PR ports/174139 has just been submitted. >>> >>> If it contains a patch for an upgrade, an enhancement or a bug fix >>> you agree on, reply to this email stating that you approve the patch >>> and a committer will take care of it. >>> >>> The full text of the PR can be found at: >>> http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/174139 >> >> Please find attached a diff that includes this fix as well as >> updating >> to 1.10.5 (stable). > > Looks good, currently testing in a tinderbox. Should I commit it > afterwards? Yes please. If I find some time, I might submit a devel package too. Rusty
Responsible Changed From-To: freebsd-ports-bugs->amdmi3 My PR
State Changed From-To: feedback->closed Committed. Thanks!
* Rusty Nejdl (rnejdl@ringofsaturn.com) wrote: > > Looks good, currently testing in a tinderbox. Should I commit it > > afterwards? > > Yes please. If I find some time, I might submit a devel package too. Done. I've also updated plist (gd locale was added) and added BROKEN for WITH_POOLALLOC. The latter build error happens because there's -ansi in upstream CFLAGS, but src/poolalloc.c uses C++-style comments (//). Wesnoth devs say this option is not really relevant, and wesnoth trunk doesn't have it, so I guess it should be removed from port with further updates. -- Dmitry Marakasov . 55B5 0596 FF1E 8D84 5F56 9510 D35A 80DD F9D2 F77D amdmi3@amdmi3.ru ..: jabber: amdmi3@jabber.ru http://www.amdmi3.ru