Bug 174139 - [PATCH] games/wesnoth: fix plist
Summary: [PATCH] games/wesnoth: fix plist
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Dmitry Marakasov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-05 02:30 UTC by Dmitry Marakasov
Modified: 2012-12-09 16:50 UTC (History)
1 user (show)

See Also:


Attachments
wesnoth-1.10.4.patch (1.11 KB, patch)
2012-12-05 02:30 UTC, Dmitry Marakasov
no flags Details | Diff
wesnoth-1.10.5.diff (1.52 KB, patch)
2012-12-05 02:36 UTC, rnejdl
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description rnejdl 2012-12-05 02:28:11 UTC
Dimitry,

Thanks!  I was already working on updating the wesnoth port so I will 
include this.

Rusty Nejdl
Comment 1 Dmitry Marakasov 2012-12-05 02:30:00 UTC
- Fix plist for WITHOUT_SERVER case (http://people.freebsd.org/~amdmi3/wesnoth-noserver-1.10.4.log)
- Remove unneeded apostrophe escaping

Port maintainer (rnejdl@ringofsaturn.com) is cc'd.

Generated with FreeBSD Port Tools 0.99_6 (mode: change, diff: ports)
Comment 2 Edwin Groothuis freebsd_committer 2012-12-05 02:30:07 UTC
Maintainer of games/wesnoth,

Please note that PR ports/174139 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/174139

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 3 Edwin Groothuis freebsd_committer 2012-12-05 02:30:08 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 4 rnejdl 2012-12-05 02:36:23 UTC
On 2012-12-05 02:30, Edwin Groothuis wrote:
> Maintainer of games/wesnoth,
> 
> Please note that PR ports/174139 has just been submitted.
> 
> If it contains a patch for an upgrade, an enhancement or a bug fix
> you agree on, reply to this email stating that you approve the patch
> and a committer will take care of it.
> 
> The full text of the PR can be found at:
>     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/174139

Please find attached a diff that includes this fix as well as updating 
to 1.10.5 (stable).

Rusty Nejdl
Comment 5 Dmitry Marakasov 2012-12-05 14:25:18 UTC
* Rusty Nejdl (rnejdl@ringofsaturn.com) wrote:

> > Maintainer of games/wesnoth,
> > 
> > Please note that PR ports/174139 has just been submitted.
> > 
> > If it contains a patch for an upgrade, an enhancement or a bug fix
> > you agree on, reply to this email stating that you approve the patch
> > and a committer will take care of it.
> > 
> > The full text of the PR can be found at:
> >     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/174139
> 
> Please find attached a diff that includes this fix as well as updating 
> to 1.10.5 (stable).

Looks good, currently testing in a tinderbox. Should I commit it
afterwards?

-- 
Dmitry Marakasov   .   55B5 0596 FF1E 8D84 5F56  9510 D35A 80DD F9D2 F77D
amdmi3@amdmi3.ru  ..:  jabber: amdmi3@jabber.ru    http://www.amdmi3.ru
Comment 6 rnejdl 2012-12-05 14:26:42 UTC
On 2012-12-05 08:25, Dmitry Marakasov wrote:
> * Rusty Nejdl (rnejdl@ringofsaturn.com) wrote:
> 
>>> Maintainer of games/wesnoth,
>>> 
>>> Please note that PR ports/174139 has just been submitted.
>>> 
>>> If it contains a patch for an upgrade, an enhancement or a bug fix
>>> you agree on, reply to this email stating that you approve the patch
>>> and a committer will take care of it.
>>> 
>>> The full text of the PR can be found at:
>>>     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/174139
>> 
>> Please find attached a diff that includes this fix as well as 
>> updating
>> to 1.10.5 (stable).
> 
> Looks good, currently testing in a tinderbox. Should I commit it
> afterwards?

Yes please.  If I find some time, I might submit a devel package too.

Rusty
Comment 7 Dmitry Marakasov freebsd_committer 2012-12-09 16:39:09 UTC
Responsible Changed
From-To: freebsd-ports-bugs->amdmi3

My PR
Comment 8 Dmitry Marakasov freebsd_committer 2012-12-09 16:41:04 UTC
State Changed
From-To: feedback->closed

Committed. Thanks!
Comment 9 Dmitry Marakasov 2012-12-09 16:44:13 UTC
* Rusty Nejdl (rnejdl@ringofsaturn.com) wrote:

> > Looks good, currently testing in a tinderbox. Should I commit it
> > afterwards?
> 
> Yes please.  If I find some time, I might submit a devel package too.

Done. I've also updated plist (gd locale was added) and added BROKEN for
WITH_POOLALLOC. The latter build error happens because there's -ansi in
upstream CFLAGS, but src/poolalloc.c uses C++-style comments (//). Wesnoth
devs say this option is not really relevant, and wesnoth trunk doesn't
have it, so I guess it should be removed from port with further updates.

-- 
Dmitry Marakasov   .   55B5 0596 FF1E 8D84 5F56  9510 D35A 80DD F9D2 F77D
amdmi3@amdmi3.ru  ..:  jabber: amdmi3@jabber.ru    http://www.amdmi3.ru