Bug 175757 - [xen] [patch] xen pvhvm looses keyboard input from VNC
Summary: [xen] [patch] xen pvhvm looses keyboard input from VNC
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: kern (show other bugs)
Version: Unspecified
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-xen (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-01 10:40 UTC by Roger Pau Monné
Modified: 2014-06-05 16:13 UTC (History)
1 user (show)

See Also:


Attachments
file.diff (989 bytes, patch)
2013-02-01 10:40 UTC, Roger Pau Monné
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Roger Pau Monné 2013-02-01 10:40:00 UTC
I've tried a FreeBSD guest using the XENHVM kernel (release 
9.1), and I've found that when using the XENHVM kernel the keyboard 
input form the vnc client stops working (output to the vnc seems to be 
ok thought), so I have to set up a serial port before switching to 
XENHVM or there's no way to interact with the guest (apart from 
ssh of course).

HEAD also seems to be experiencing the same issue. Is this 
expected/know? I'm using Xen unstable and the device model is  
Qemu-upstream.

Fix: The problem is that we set all devices in xenstore that we don't know how to handle to state '6' (closed), which is not right. We should not mess with the state of devices that we cannot handle. The following patch fixes the problem by probing the devices first, and only try to attach the ones that we can handle.

---
From: Roger Pau Monne <roger.pau@citrix.com>
Date: Thu, 31 Jan 2013 17:24:48 +0000
Subject: [PATCH] xenbus: fix device detection

Devices that cannot be handled should not be closed, instead leave
them as is. This prevents closing the vkbd device, which has the
effect of making Qemu stop sending keys to the guest.

Tested with qemu-xen-traditional, qemu-xen and qemu stubdomains, all
working as expected.
---
 sys/xen/xenbus/xenbusb.c |   19 ++++++++++++++++++-
 1 files changed, 18 insertions(+), 1 deletions(-)
How-To-Repeat: Install a FeeeBSD guest in Xen and switch to the XENHVM kernel, the keyboard on the VNC stops sending keys to the guest.
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2013-02-03 01:55:36 UTC
Responsible Changed
From-To: freebsd-bugs->freebsd-xen

Over to maintainer(s).
Comment 2 Roger Pau Monné freebsd_committer freebsd_triage 2014-06-05 16:13:24 UTC
Patch has been committed.