[corn:~]> ldd /usr/local/bin/xclock | grep iconv libiconv.so.3 => /usr/local/lib/libiconv.so.3 (0x801242000) This is not recorded in dependency list. Fix: Patch attached with submission follows:
Responsible Changed From-To: freebsd-ports-bugs->freebsd-x11 Over to maintainer (via the GNATS Auto Assign Tool)
Responsible Changed From-To: freebsd-x11->x11 Over to maintainer
xclock will use iconv if it's there, but it's optional. From xclock's configure on a system without iconv... checking for iconv... no, consider installing GNU libiconv and... % ldd /usr/local/bin/xclock | grep iconv || echo nope nope So forcing iconv into xclock's dependencies is probably wrong in this case.
Dnia 2013-02-07, o godz. 12:27:11 John Hein <jhein@symmetricom.com> napisa=B3(a): >xclock will use iconv if it's there, but it's optional. > >From xclock's configure on a system without iconv... > >checking for iconv... no, consider installing GNU libiconv > >and... > >% ldd /usr/local/bin/xclock | grep iconv || echo nope >nope > > >So forcing iconv into xclock's dependencies is probably wrong in this >case. On systems with iconv installed (this is pretty common package) this means incomplete dependency list... My patch is just a proposition and if maintainer decide to turn off linking with iconv it's fine too. For optional features we have options framework. --=20 pozdrawiam / with regards Pawe=B3 P=EAkala
On 7 February 2013 14:30, John Hein <jhein@symmetricom.com> wrote: > The following reply was made to PR ports/175935; it has been noted by GNATS. > > From: John Hein <jhein@symmetricom.com> > To: <pawel@FreeBSD.org> > Cc: bug-followup@freebsd.org > Subject: Re: ports/175935: x11-clocks/xclock links to iconv > Date: Thu, 7 Feb 2013 12:27:11 -0700 > > xclock will use iconv if it's there, but it's optional. Many ports do this. This is entirely a bug. Imagine building on a different machine than one will be running. > From xclock's configure on a system without iconv... The correct fix is to explicitly disable iconv, explicitly enable it, or make it an OPTION. As is though, is buggy. -- Eitan Adler
Eitan Adler wrote at 14:38 -0500 on Feb 7, 2013: > The correct fix is to explicitly disable iconv, explicitly enable it, > or make it an OPTION. Fair enough. OPTION it (default off - who uses iconv with xclock?). More work for the maintainer, but that seems like the best choice given our current tools. It'd be nice if we could have dynamic dependencies (dynamic at port build time, that is) for cases like this where the user couldn't really care either way about the feature, but removing a dependency breaks it.
Responsible Changed From-To: x11->freebsd-x11 Canonicalize assignment.
Author: zeising Date: Thu Jun 27 13:39:18 2013 New Revision: 321891 URL: http://svnweb.freebsd.org/changeset/ports/321891 Log: Add explicit dependency on iconv. Bump portrevision. PR: ports/175935 Submitted by: Pawel Pekala <pawel@FreeBSD.org> Modified: head/x11-clocks/xclock/Makefile Modified: head/x11-clocks/xclock/Makefile ============================================================================== --- head/x11-clocks/xclock/Makefile Thu Jun 27 13:37:03 2013 (r321890) +++ head/x11-clocks/xclock/Makefile Thu Jun 27 13:39:18 2013 (r321891) @@ -2,6 +2,7 @@ PORTNAME= xclock PORTVERSION= 1.0.6 +PORTREVISION= 1 CATEGORIES= x11-clocks MAINTAINER= x11@FreeBSD.org @@ -9,6 +10,7 @@ COMMENT= Analog and digital clock for X XORG_CAT= app USE_XORG= xrender xft xkbfile xt xaw +USES= iconv MAN1= xclock.1 _______________________________________________ svn-ports-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-ports-all To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
State Changed From-To: open->closed Committed. Thanks!