Bug 176196 - [PATCH] games/quake2-ctf: Set NO_WRKSUBDIR and BUILD_WRKSRC instead of abusing WRKSRC.
Summary: [PATCH] games/quake2-ctf: Set NO_WRKSUBDIR and BUILD_WRKSRC instead of abusin...
Status: Open
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Alexey Dokuchaev
URL:
Keywords: needs-patch
Depends on:
Blocks:
 
Reported: 2013-02-16 16:20 UTC by Christoph Mallon
Modified: 2019-01-25 21:12 UTC (History)
1 user (show)

See Also:


Attachments
0001-games-quake2-ctf-Set-NO_WRKSUBDIR-and-BUILD_WRKSRC-i.patch (1.65 KB, patch)
2013-02-16 16:20 UTC, Christoph Mallon
tobik: maintainer-approval-
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Christoph Mallon 2013-02-16 16:20:00 UTC
Set NO_WRKSUBDIR and BUILD_WRKSRC instead of abusing WRKSRC.

Fix: Please apply this patch.
Comment 1 Edwin Groothuis freebsd_committer 2013-02-16 16:20:08 UTC
Responsible Changed
From-To: freebsd-ports-bugs->danfe

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Alexey Dokuchaev freebsd_committer 2014-07-23 08:21:06 UTC
Sorry for belated reply.  I'm not convinced that WRKSRC is really being *abused* here, nor that adding three new variables (NO_WRKSUBDIR, BUILD_WRKSRC, and PATCH_WRKSRC) just to slightly shorten two entries in USE_DOS2UNIX is justified.

However I agree that logically separating BUILD_WRKSRC would probably be nice; I'll think of a better way to implement it.
Comment 3 Walter Schwarzenfeld freebsd_triage 2018-01-10 21:05:57 UTC
Is this still relevant.
Comment 4 Alexey Dokuchaev freebsd_committer 2018-01-11 09:25:50 UTC
(Is this a question?  If so, please properly terminate questions with a question mark.)

Yes, it is still relevant, as I've explained in the comment #2; I simply didn't have a chance to revisit it yet.