Bug 177097 - [PATCH] mail/milter-greylist loses dumpfile following upgrade
Summary: [PATCH] mail/milter-greylist loses dumpfile following upgrade
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Hajimu UMEMOTO
Depends on:
Reported: 2013-03-19 01:40 UTC by John Marshall
Modified: 2013-03-20 16:16 UTC (History)
0 users

See Also:

milter-greylist.diff (629 bytes, patch)
2013-03-19 01:40 UTC, John Marshall
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description John Marshall 2013-03-19 01:40:00 UTC
Following upgrade to 4.4.1, milter-greylist looks for its dumpfile in a
different (non-existent) location...

  milter-greylist: cannot read dumpfile "/usr/local/var/milter-greylist/greylist.db"
  milter-greylist: starting with an empty greylist

The problem arises because the configure.ac defines the default dumpfile
location as ${prefix}/var...  We could patch config files but since the
port already hard-codes the expected dumpfile location in the Makefile,
I suggest we just use the configure argument to pass that location to
the build.  The attached patch addes that configure argument.

I notice that ports/176950 (4.4.3 update) is in progress.  Perhaps this
patch could augment the commit for that PR?

Thank you for maintaining this port.
Comment 1 Edwin Groothuis freebsd_committer 2013-03-19 01:40:08 UTC
Maintainer of mail/milter-greylist,

Please note that PR ports/177097 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:

Edwin Groothuis via the GNATS Auto Assign Tool
Comment 2 Edwin Groothuis freebsd_committer 2013-03-19 01:40:09 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 dfilter service freebsd_committer 2013-03-20 15:51:25 UTC
Author: ume
Date: Wed Mar 20 15:51:13 2013
New Revision: 314741
URL: http://svnweb.freebsd.org/changeset/ports/314741

  Correct dumpfile location.
  PR:		ports/177097
  Submitted by:	John Marshall <john.marshall__at__riverwillow.com.au>
  Reviewed by:	Mikhail Tsatsenko <m.tsatsenko__at__gmail.com> (maintainer)
  Approved by:	Mikhail Tsatsenko <m.tsatsenko__at__gmail.com> (maintainer)


Modified: head/mail/milter-greylist/Makefile
--- head/mail/milter-greylist/Makefile	Wed Mar 20 15:22:04 2013	(r314740)
+++ head/mail/milter-greylist/Makefile	Wed Mar 20 15:51:13 2013	(r314741)
@@ -75,7 +75,8 @@ LIBS+=		${PTHREAD_LIBS}
 CONFIGURE_ARGS+=	--with-user=mailnull --with-libmilter=${MILTERBASE} \
-			--enable-dnsrbl --with-thread-safe-resolver
+			--enable-dnsrbl --with-thread-safe-resolver \
+			--with-dumpfile=/var/milter-greylist/greylist.db
 ALL_TARGET=	milter-greylist
svn-ports-all@freebsd.org mailing list
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 4 Hajimu UMEMOTO freebsd_committer 2013-03-20 16:14:55 UTC
State Changed
From-To: feedback->closed

Thanks committed! 

Comment 5 Hajimu UMEMOTO freebsd_committer 2013-03-20 16:14:55 UTC
Responsible Changed
From-To: freebsd-ports-bugs->ume

Thanks committed!