Bug 177356 - Mk/bsd.port.mk: remove support for USE_CMAKE and KDE4_BUILDENV
Summary: Mk/bsd.port.mk: remove support for USE_CMAKE and KDE4_BUILDENV
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Martin Wilke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-24 21:10 UTC by Max Brazhnikov
Modified: 2013-05-31 17:10 UTC (History)
0 users

See Also:


Attachments
file.diff (1.61 KB, patch)
2013-03-24 21:10 UTC, Max Brazhnikov
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Max Brazhnikov freebsd_committer 2013-03-24 21:10:00 UTC
Remove support for USE_CMAKE and KDE4_BUILDENV, they are no of use anymore.
Unconditionally set CMAKE_ARGS in bsd.python.mk, as it shouldn't affect non-cmake ports

Fix: Patch attached with submission follows:
Comment 1 Edwin Groothuis freebsd_committer 2013-03-24 21:10:08 UTC
Responsible Changed
From-To: freebsd-ports-bugs->portmgr

bsd.port.mk is portmgr territory (via the GNATS Auto Assign Tool)
Comment 2 Martin Wilke freebsd_committer 2013-03-24 23:08:28 UTC
Responsible Changed
From-To: portmgr->miwi

I'll take it.
Comment 3 dfilter service freebsd_committer 2013-05-31 17:03:56 UTC
Author: miwi
Date: Fri May 31 16:03:49 2013
New Revision: 319529
URL: http://svnweb.freebsd.org/changeset/ports/319529

Log:
  - Remove support for USE_CMAKE and KDE4_BUILDENV, they are no of use anymore.
    Unconditionally set CMAKE_ARGS in bsd.python.mk, as it don't affect non-cmake ports
  
  PR:		177356
  Submitted by:	makc@

Modified:
  head/Mk/bsd.python.mk

Modified: head/Mk/bsd.python.mk
==============================================================================
--- head/Mk/bsd.python.mk	Fri May 31 15:54:30 2013	(r319528)
+++ head/Mk/bsd.python.mk	Fri May 31 16:03:49 2013	(r319529)
@@ -671,10 +671,9 @@ RUN_DEPENDS+=	${PYTHON_SITELIBDIR}/twist
 # This in turn might cause it to link against version X while using the
 # includes of version Y, leading to a broken port.
 # Enforce a certain Python version by using PYTHON_VER for cmake.
-.if defined(USE_CMAKE)
+
 CMAKE_ARGS+=	-DPythonLibs_FIND_VERSION:STRING="${PYTHON_VER}" \
 		-DPythonInterp_FIND_VERSION:STRING="${PYTHON_VER}"
-.endif
 
 .endif		# !defined(_POSTMKINCLUDED) && !defined(Python_Pre_Include)
 
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 4 Martin Wilke freebsd_committer 2013-05-31 17:03:57 UTC
State Changed
From-To: open->closed

q