Bug 178072 - [PATCH] [bsd.port.mk] look for Makefile.local in ${PORTSDIR} as well as ${.CURDIR}
Summary: [PATCH] [bsd.port.mk] look for Makefile.local in ${PORTSDIR} as well as ${.CU...
Status: In Progress
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Ports Framework (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Port Management Team
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-23 06:40 UTC by Enji Cooper
Modified: 2014-11-13 22:07 UTC (History)
1 user (show)

See Also:


Attachments
file.diff (2.84 KB, patch)
2013-04-23 06:40 UTC, Enji Cooper
no flags Details | Diff
search-for-Makefile.local-in-PORTSDIR.patch.txt (1.14 KB, text/plain; x-unix-mode=0644)
2013-04-23 23:56 UTC, Garrett Cooper
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Enji Cooper freebsd_committer 2013-04-23 06:40:00 UTC
The attached patch looks for Makefile.local in PORTSDIR as well as .CURDIR, thus being a bit less braindead when it comes to looking for site-localizations when there are a large number of ports categories.

Thus one only needs to have one Makefile.local instead of n-categories worth when trying to apply non-invasive changes to a ports tree.

Fix: Patch attached with submission follows:
Comment 1 Garrett Cooper 2013-04-23 23:56:54 UTC
	The attached patch is more correct than the previous one.
1. It removes noise from another patch I submitted (ports/178070).
2. It also fixes the case where double inclusion would be done (${.CURDIR} == ${PORTSDIR}). Granted, this check could probably be improved, but this seems sane enough as-is.
Thanks!
-Garrett
Comment 2 Mark Linimon freebsd_committer freebsd_triage 2013-05-03 00:12:28 UTC
Responsible Changed
From-To: freebsd-ports-bugs->portmgr

Over to maintainer(s).
Comment 3 Bryan Drewery freebsd_committer 2013-08-30 02:45:51 UTC
Responsible Changed
From-To: portmgr->bdrewery

I'll take it.
Comment 4 Carlo Strub freebsd_committer 2014-09-14 10:42:47 UTC
Is this PR still relevant?