Bug 178412 - [smbfs] Coredump when smbfs mounted
Summary: [smbfs] Coredump when smbfs mounted
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: kern (show other bugs)
Version: Unspecified
Hardware: Any Any
: Normal Affects Only Me
Assignee: Andrey V. Elsukov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-08 07:00 UTC by v.chernyadev
Modified: 2014-05-02 22:46 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description v.chernyadev 2013-05-08 07:00:00 UTC 
When mounted many smbfs like this:
# mount
//MNTUSER@PC1/WINSHARE1 on /home/pc1 (smbfs, noatime)
//MNTUSER@PC2/WINSHARE2 on /home/pc2 (smbfs, noatime)
//MNTUSER@PC3/WINSHARE3 on /home/pc3 (smbfs, noatime)
//MNTUSER@PC4/WINSHARE4 on /home/pc4 (smbfs, noatime)
(and so on)

And users and FreeBSD are actively using WINSHAREX (/home/pcX), then if some of these Windows PC's shuts down without unmount, the FreeBSD may reboot or going to the coredump. When mounted more than 10 smbfs, the reboots may repeated each day. Else reboots 1-2 times at week.

How-To-Repeat: Mount many smbfs (10 or better 20), simulate some reads and writes both on Windows and FreeBSD. Randomly turn on and off the Windows PC's wihout unmount smbfs.
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2013-05-08 22:31:55 UTC 
Responsible Changed
From-To: freebsd-bugs->freebsd-fs

Over to maintainer(s).
Comment 2 dfilter service freebsd_committer freebsd_triage 2014-04-17 13:22:13 UTC 
Author: ae
Date: Thu Apr 17 12:22:08 2014
New Revision: 264600
URL: http://svnweb.freebsd.org/changeset/base/264600

Log:
  Remove redundant unlock.
  
  This code was removed from the opensolaris and darwin's
  netsmb implementations, in DfBSD it also has been disabled.
  
  PR:		36566, 87859, 139407, 161579, 175557, 178412, 186652
  MFC after:	2 weeks
  Sponsored by:	Yandex LLC

Modified:
  head/sys/netsmb/smb_iod.c

Modified: head/sys/netsmb/smb_iod.c
==============================================================================
--- head/sys/netsmb/smb_iod.c	Thu Apr 17 12:16:51 2014	(r264599)
+++ head/sys/netsmb/smb_iod.c	Thu Apr 17 12:22:08 2014	(r264600)
@@ -87,8 +87,6 @@ smb_iod_invrq(struct smbiod *iod)
 	 */
 	SMB_IOD_RQLOCK(iod);
 	TAILQ_FOREACH(rqp, &iod->iod_rqlist, sr_link) {
-		if (rqp->sr_flags & SMBR_INTERNAL)
-			SMBRQ_SUNLOCK(rqp);
 		rqp->sr_flags |= SMBR_RESTART;
 		smb_iod_rqprocessed(rqp, ENOTCONN);
 	}
_______________________________________________
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
Comment 3 Andrey V. Elsukov freebsd_committer freebsd_triage 2014-05-02 22:45:49 UTC 
State Changed
From-To: open->closed

Fixed in head/ and stable/10.
Comment 4 Andrey V. Elsukov freebsd_committer freebsd_triage 2014-05-02 22:45:49 UTC 
Responsible Changed
From-To: freebsd-fs->ae

Take it.