Bug 178431 - graphics/geos hardcodes PHP 5.4 version
Summary: graphics/geos hardcodes PHP 5.4 version
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: John Marino
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-08 21:20 UTC by ebay
Modified: 2014-06-15 13:40 UTC (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description ebay 2013-05-08 21:20:00 UTC
graphics/geos has an option to enable a PHP module but it has the 5.4 port hardcoded:

BUILD_DEPENDS+=         ${LOCALBASE}/bin/php-config:${PORTSDIR}/lang/php5

I'd prefer this use USE_PHP= yes or whatever is more appropriate for supporting the currently installed version of PHP.  I got it to compile with php 5.2 and we'll be testing it shortly.
Comment 1 Edwin Groothuis freebsd_committer 2013-05-08 21:20:07 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 2 Edwin Groothuis freebsd_committer 2013-05-08 21:20:07 UTC
Maintainer of graphics/geos,

Please note that PR ports/178431 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/178431

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 3 ebay 2013-10-14 15:42:53 UTC
It does work with PHP 5.2, and now we're moving to PHP 5.3 and I have to
adjust it again.
Comment 4 John Marino freebsd_committer 2014-06-10 12:01:56 UTC
Konstantin,
It looks like there was a period where you had 4 consecutive maintainer timeouts, which is enough to get the port reset (easily).

Since then you were active twice, but that was in 2013, during the same timeframe as this PR.

Can you respond quickly to this PR?
Otherwise we'll probably have to reset the port and make the suggested change, but I'd certainly rather you stay in charge.
Comment 5 John Marino freebsd_committer 2014-06-10 12:03:52 UTC
mcdouga, for your part, you should provide an actual patch rather than describe the problem and solution.
Comment 6 John Marino freebsd_committer 2014-06-12 10:36:29 UTC
mcdouga9,
If I don't see any response from you pretty quickly, I'm going to lose interest in this PR and release it back to the heap.

If you want me to take this PR seriously, please provide a patch or at least respond so I know you're looking at this.


Konstantin,
If mcdouga9 responds and you don't, I'm going to set this port as unmaintained.  I may do that regardless.
Comment 7 commit-hook freebsd_committer 2014-06-15 13:38:54 UTC
A commit references this bug:

Author: marino
Date: Sun Jun 15 13:38:37 UTC 2014
New revision: 357881
URL: http://svnweb.freebsd.org/changeset/ports/357881

Log:
  graphics/geos: Fix PHP option, reset mainatainer

  The PHP option was hardcoded to lang/php5, but it reportedly works on other
  versions of PHP.  It also installs a PHP module, so it should have had a
  run depends on PHP as well as a build depends (hence the revump)

  Also:
    * Remove USE_LDCONFIG, I don't see why it's here
    * convert USE_BZIP2
    * Reset maintainer due to history of timeouts and non-responsiveness to
      this PR
    * respect 80 columns

  PR:		178431
  Submitted by:	mcdouga9 (egr.msu.edu)
  Fixes by:	marino

Changes:
  head/graphics/geos/Makefile
Comment 8 John Marino freebsd_committer 2014-06-15 13:40:28 UTC
I just knocked something out in light of the non-responsiveness on all parties.