Bug 179127 - math/gmp should set CONFIGURE_ENV+= ABI="mode64" for ppc64
Summary: math/gmp should set CONFIGURE_ENV+= ABI="mode64" for ppc64
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Kubilay Kocak
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-30 22:30 UTC by Justin Hibbits
Modified: 2013-12-14 04:53 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Justin Hibbits 2013-05-30 22:30:02 UTC
math/gmp doesn't allow "ABI=64" on powerpc64, so the makefile should instead set it to mode64

Fix: 

Set CONFIGURE_ENV+= ABI="mode64" for powerpc64
How-To-Repeat: Build math/gmp on ppc64
Comment 1 Edwin Groothuis freebsd_committer 2013-05-30 22:30:10 UTC
Responsible Changed
From-To: freebsd-ports-bugs->ale

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Kubilay Kocak freebsd_committer freebsd_triage 2013-12-14 02:19:14 UTC
Responsible Changed
From-To: ale->koobs

I'll take it (maintainer timeout, 6 months)
Comment 3 dfilter service freebsd_committer 2013-12-14 04:47:31 UTC
Author: koobs
Date: Sat Dec 14 04:47:22 2013
New Revision: 336420
URL: http://svnweb.freebsd.org/changeset/ports/336420

Log:
  The MCPU_OPTS conditional block currently incorrectly sets ABI=64 for
  all ARCH strings that in 64. GMP expects mode64, mode32 or 32 as valid values
  for the ABI option [1]. Using an invalid value causes the following
  build error on powerpc64:
  
      configure: error: ABI=64 is not among the following valid choices:
      mode64 mode32 32
  
  This is the minimum change to set the correct "mode64" ABI value when
  ARCH is powerpc64, while also keeping all other semantics the same. A
  more complete refactor of this port is possible, but would need an
  exp-run to test for regressions.
  
  The change was tested on powerpc64 (thanks justin) and amd64 (for regression)
  
  While I'm here:
  
  - Remove indefinite article from COMMENT
  
  [1] https://gmplib.org/manual/Build-Options.html
  
  PR:		ports/179127
  Submitted by:	jhibbits
  Reviewed by:	jhibbits, ak
  Approved by:	maintainer timeout (6 months)

Modified:
  head/math/gmp/Makefile

Modified: head/math/gmp/Makefile
==============================================================================
--- head/math/gmp/Makefile	Sat Dec 14 04:39:27 2013	(r336419)
+++ head/math/gmp/Makefile	Sat Dec 14 04:47:22 2013	(r336420)
@@ -8,7 +8,7 @@ MASTER_SITES=	${MASTER_SITE_GNU}
 MASTER_SITE_SUBDIR=	gmp
 
 MAINTAINER=	ale@FreeBSD.org
-COMMENT=	A free library for arbitrary precision arithmetic
+COMMENT=	Free library for arbitrary precision arithmetic
 
 LICENSE=	LGPL3
 
@@ -34,7 +34,11 @@ INFO=		gmp
 .if ! ${PORT_OPTIONS:MCPU_OPTS}
 CONFIGURE_ARGS+=--build=${ARCH}-portbld-freebsd${OSREL}
 .elif ${ARCH:S/64//} != ${ARCH}
+.if ${ARCH} == powerpc64
+CONFIGURE_ENV+=	ABI="mode64"
+.else
 CONFIGURE_ENV+=	ABI="64"
+.endif
 .else
 CONFIGURE_ENV+=	ABI="32"
 .endif
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 4 Kubilay Kocak freebsd_committer freebsd_triage 2013-12-14 04:53:21 UTC
State Changed
From-To: open->closed

Committed. Thanks Justin!