Bug 179145 - [PATCH] net-mgmt/devmon: fix pidfile issues
Summary: [PATCH] net-mgmt/devmon: fix pidfile issues
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Steve Wills
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-31 14:50 UTC by Mark Felder
Modified: 2013-06-03 14:40 UTC (History)
0 users

See Also:


Attachments
file.diff (573 bytes, patch)
2013-05-31 14:50 UTC, Mark Felder
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Felder freebsd_committer 2013-05-31 14:50:00 UTC
Previous update to devmon was missing my fixes to the default pidfile location, required because devmon runs as its own user. The rc script is already expecting it in /var/run/devmon/. This makes the example config show /var/run/devmon/ as the default/recommended path, and makes the daemon actually use /var/run/devmon/ if the config file isn't defining PIDFILE

Fix: Patch attached with submission follows:
Comment 1 Edwin Groothuis freebsd_committer 2013-05-31 14:50:16 UTC
Responsible Changed
From-To: freebsd-ports-bugs->swills

swills@ wants this submitter's PRs (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer 2013-06-03 14:33:00 UTC
Author: swills
Date: Mon Jun  3 13:32:53 2013
New Revision: 319777
URL: http://svnweb.freebsd.org/changeset/ports/319777

Log:
  - Fix pidfile issues
  
  PR:		ports/179145
  Submitted by:	Mark Felder <feld@feld.me> (maintainer)

Modified:
  head/net-mgmt/devmon/Makefile

Modified: head/net-mgmt/devmon/Makefile
==============================================================================
--- head/net-mgmt/devmon/Makefile	Mon Jun  3 12:45:59 2013	(r319776)
+++ head/net-mgmt/devmon/Makefile	Mon Jun  3 13:32:53 2013	(r319777)
@@ -3,7 +3,7 @@
 
 PORTNAME=	devmon
 DISTVERSION=	0.3.1-beta1
-PORTREVISION=	1
+PORTREVISION=	2
 CATEGORIES=	net-mgmt
 MASTER_SITES=	SF/${PORTNAME}/${PORTNAME}/${DISTVERSION}
 
@@ -26,12 +26,17 @@ SUB_LIST=	USERS=${USERS} \
 
 OPTIONS_DEFINE=	MYSQL
 
+REINPLACE_ARGS=	-i ''
+
 .include <bsd.port.options.mk>
 
 .if ${PORT_OPTIONS:MMYSQL}
 USE_MYSQL=	yes
 .endif
 
+post-patch:
+	@${REINPLACE_CMD} -e 's|/var/run/devmon.pid|/var/run/devmon/devmon.pid|g' ${WRKSRC}/devmon.cfg ${WRKSRC}/modules/dm_config.pm
+
 pre-install:
 	(cd ${WRKSRC} && ${MV} devmon.cfg devmon.cfg.dist)
 
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 3 Steve Wills freebsd_committer 2013-06-03 14:33:31 UTC
State Changed
From-To: open->closed

Committed. Thanks!