Bug 179287 - [PATCH] games/euchre: Fix port, bad C++ code, add icons, docs, take maintainership
Summary: [PATCH] games/euchre: Fix port, bad C++ code, add icons, docs, take maintaine...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Rusmir Dusko
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-04 03:00 UTC by nemysis
Modified: 2013-10-21 22:50 UTC (History)
1 user (show)

See Also:


Attachments
euchre-0.8_1.patch (2.50 KB, patch)
2013-06-04 03:00 UTC, nemysis
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description nemysis 2013-06-04 03:00:00 UTC
- Bump portrevision
- Fix port
- Trim master sites
- Add Icons
- Trim desktop entry
- Add docs
- Fix bad C++ code
- Trim pkg-descr
- Take maintainership

Generated and tested manually, tested with port test and with RedPorts, with FreeBSD Port Tools 0.99_7 (mode: change, diff: ports)

How-To-Repeat: 
Build log

https://redports.org/buildarchive/20130604010101-31643/
Comment 1 Edwin Groothuis freebsd_committer 2013-06-04 03:00:08 UTC
Responsible Changed
From-To: freebsd-ports-bugs->beech

beech@ wants this submitter's PRs (via the GNATS Auto Assign Tool)
Comment 2 Rusmir Dusko freebsd_committer 2013-10-21 11:39:26 UTC
Responsible Changed
From-To: beech->nemysis

I'll take it.
Comment 3 Rusmir Dusko freebsd_committer 2013-10-21 22:35:11 UTC
State Changed
From-To: open->closed

Committed. Thanks!
Comment 4 dfilter service freebsd_committer 2013-10-21 22:40:59 UTC
Author: nemysis
Date: Mon Oct 21 21:40:50 2013
New Revision: 331197
URL: http://svnweb.freebsd.org/changeset/ports/331197

Log:
  - Bump PORTREVISION
  - Change master sites, add icon
  - Pass maintainership to submitter
  - Add DOCS and Option
  - Change desktop entry
  - Fix port and bad C++ code
  - Change pkg-descr
  
  PR:		ports/179287
  Submitted by:	nemysis (self)
  Approved by:	pawel / wg (mentors, implicit)

Modified:
  head/games/euchre/Makefile
  head/games/euchre/distinfo
  head/games/euchre/pkg-descr   (contents, props changed)

Modified: head/games/euchre/Makefile
==============================================================================
--- head/games/euchre/Makefile	Mon Oct 21 21:31:04 2013	(r331196)
+++ head/games/euchre/Makefile	Mon Oct 21 21:40:50 2013	(r331197)
@@ -3,26 +3,45 @@
 
 PORTNAME=	euchre
 PORTVERSION=	0.8
+PORTREVISION=	1
 CATEGORIES=	games
-MASTER_SITES=	SF/${PORTNAME}/${PORTNAME}/${PORTNAME}-${PORTVERSION}
+MASTER_SITES=	SF/${PORTNAME}/${PORTNAME}/${PORTNAME}-${PORTVERSION} \
+		SF/nemysisfreebsdp/${CATEGORIES}/:icons
+DISTFILES=	${PORTNAME}-${DISTVERSION}${EXTRACT_SUFX} \
+		${PORTNAME}.png:icons
+EXTRACT_ONLY=	${PORTNAME}-${DISTVERSION}${EXTRACT_SUFX}
 
-MAINTAINER=	ports@FreeBSD.org
+MAINTAINER=	nemysis@FreeBSD.org
 COMMENT=	Very popular card game with variable skill levels
 
-LICENSE=	GPLv2 # (or later)
+LICENSE=	GPLv2
 
 USES=		pkgconfig
 USE_GNOME=	gtk20
 GNU_CONFIGURE=	yes
 CONFIGURE_ARGS=	--disable-silent-rules
 
-PLIST_FILES=	bin/euchre
+PLIST_FILES=	bin/${PORTNAME} \
+		share/pixmaps/${PORTNAME}.png
 
-DESKTOP_ENTRIES="Euchre" "" "" "${PORTNAME}" "" true
+PORTDOCS=	AUTHORS ChangeLog README TODO
+
+DESKTOP_ENTRIES="Euchre" "${COMMENT}" "${PORTNAME}" \
+		"${PORTNAME}" "Game;CardGame;" false
+
+OPTIONS_DEFINE=	DOCS
 
-NO_STAGE=	yes
 post-patch:
 	@${REINPLACE_CMD} -e \
 		'/^AM_/s|-Werror||' ${WRKSRC}/configure
+	@${REINPLACE_CMD} -e 's|int)|long int)|g' \
+		${WRKSRC}/src/gui/callbacks.cpp ${WRKSRC}/src/lib/Game.cpp
+
+post-install:
+	${INSTALL_DATA} ${_DISTDIR}/${PORTNAME}.png \
+		${STAGEDIR}${PREFIX}/share/pixmaps/
+
+	@${MKDIR} ${STAGEDIR}${DOCSDIR}
+	${INSTALL_DATA} ${PORTDOCS:S|^|${WRKSRC}/|} ${STAGEDIR}${DOCSDIR}
 
 .include <bsd.port.mk>

Modified: head/games/euchre/distinfo
==============================================================================
--- head/games/euchre/distinfo	Mon Oct 21 21:31:04 2013	(r331196)
+++ head/games/euchre/distinfo	Mon Oct 21 21:40:50 2013	(r331197)
@@ -1,2 +1,4 @@
 SHA256 (euchre-0.8.tar.gz) = c339d29ea6837f344b98134ecdd7aa52fb958454bd4dd6145430b197752ed78b
 SIZE (euchre-0.8.tar.gz) = 213490
+SHA256 (euchre.png) = 94b5b20412e4bddc84ad066070843a0a3dd9504fd99fa497d8f32739c610ee31
+SIZE (euchre.png) = 6563

Modified: head/games/euchre/pkg-descr
==============================================================================
--- head/games/euchre/pkg-descr	Mon Oct 21 21:31:04 2013	(r331196)
+++ head/games/euchre/pkg-descr	Mon Oct 21 21:40:50 2013	(r331197)
@@ -1,3 +1,6 @@
-A very basic interpretation of the game 'Euchre.'
+Euchre is a card game played with the 9s, 10s, Jacks, Queens, Kings,
+and Aces of all 4 suits.  Each player is dealt 5 cards, leaving 4
+cards in the deck.  The top card of the remaining 4 is then turned
+over and this is the trump candidate.
 
 WWW: http://sourceforge.net/projects/euchre/
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"