Greetings, multimedia/vlc is utterly broken since the last change that was claimed to chase the FLAC updates. The FLAC updates are incomplete, because the FLAC include files appear to have moved into /usr/local/include/FLAC (the FLAC part is new), and vlc misses other stuff. How-To-Repeat: Update ports tree, try to update all ports, see vlc build fail with a missing stream_decoder.h include file when building its FLAC plugin. Fix that with CPPFLAGS+=${LOCALBASE}/include/FLAC and see that there are other failures, some from a missing #include <assert.h>, and other issues. My vlc configuration is: (pretty-print-config): +A52 -AALIB -ASS +AVAHI -CACA +DBUS -DEBUG -DIRAC +DOCS +DTS +DVDNAV +DVDREAD +FAAD +FLAC -FLUID -FRIBIDI +GLX -GNOMEVFS +GNUTLS -GOOM +HTTPD -JACK +LIBBLURAY -LIRC -LIVEMEDIA +LUA +MAD +MATROSKA -MODPLUG +MPEG2 +MTP -MUSEPACK -NCURSES +NLS -NOTIFY -NO_DVD +OGG +OPTIMIZED_CFLAGS +OPUS +PNG -PORTAUDIO -PROJM -PULSEAUDIO +QT4 +REALAUDIO -RUNROOT -SAMBA +SAMPLERATE -SCHROED +SDL -SERVER_ONLY -SHOUTCAST -SIDPLAY +SKINS +SPEEX -SQLITE +STREAM -SVG +TAGLIB +THEORA +TWOLAME +UPNP +V4L +VAAPI +VCD +VORBIS +X11 +X264 +XCB -XOSD +XVIDEO -ZVBI
Responsible Changed From-To: freebsd-ports-bugs->freebsd-multimedia Over to maintainer (via the GNATS Auto Assign Tool) http://www.freebsd.org/cgi/query-pr.cgi?pr=179449 Date: Mon, 10 Jun 2013 12:44:58 +0200
Hello, on my system, I could solve this problem with the attached patch, that only specifies the full path for the headers. My configuration is a little bit different, though. After applying the patch, the compilation emits lots of warning but no fatal errors. My system compiler is gcc. Please let me know if you need a build log. $ uname -a FreeBSD myhost 9.1-STABLE FreeBSD 9.1-STABLE #32 r251599: Mon Jun 10 09:20:28 CEST 2013 root@myhost:/usr/obj/usr/src/sys/GENERIC i386 $ cd /usr/ports/multimedia/vlc && make pretty-print-config +A52 +AALIB -ASS +AVAHI +CACA +DBUS -DEBUG -DIRAC +DOCS -DTS +DVDNAV +DVDREAD +FAAD +FLAC +FLUID -FRIBIDI +GLX -GNOMEVFS +GNUTLS -GOOM +HTTPD -JACK -LIBBLURAY -LIRC +LIVEMEDIA +LUA +MAD +MATROSKA -MODPLUG +MPEG2 -MTP +MUSEPACK -NCURSES +NLS +NOTIFY -NO_DVD +OGG +OPTIMIZED_CFLAGS +OPUS +PNG -PORTAUDIO -PROJM -PULSEAUDIO +QT4 +REALAUDIO -RUNROOT -SAMBA +SAMPLERATE -SCHROED +SDL -SERVER_ONLY +SHOUTCAST -SIDPLAY +SKINS +SPEEX -SQLITE +STREAM -SVG +TAGLIB +THEORA +TWOLAME -UPNP +V4L -VAAPI +VCD +VORBIS +X11 +X264 +XCB +XOSD +XVIDEO +ZVBI -- rigo http://rigo.altervista.org
Author: naddy Date: Mon Jun 10 12:52:39 2013 New Revision: 320469 URL: http://svnweb.freebsd.org/changeset/ports/320469 Log: Fix build after audio/flac 1.3.0 update. PR: 179449 Submitted by: Arrigo Marchiori <ardovm@yahoo.it> (fix) Added: head/multimedia/vlc/files/patch-modules-codec-flac.c (contents, props changed) Added: head/multimedia/vlc/files/patch-modules-codec-flac.c ============================================================================== --- /dev/null 00:00:00 1970 (empty, because file is newly added) +++ head/multimedia/vlc/files/patch-modules-codec-flac.c Mon Jun 10 12:52:39 2013 (r320469) @@ -0,0 +1,13 @@ +--- modules/codec/flac.c.orig 2013-01-25 13:30:14.000000000 +0100 ++++ modules/codec/flac.c 2013-06-10 14:39:04.000000000 +0200 +@@ -38,8 +38,8 @@ + #include <vlc_codec.h> + #include <vlc_aout.h> + +-#include <stream_decoder.h> +-#include <stream_encoder.h> ++#include <FLAC/stream_decoder.h> ++#include <FLAC/stream_encoder.h> + + #include <vlc_block_helper.h> + #include <vlc_bits.h> _______________________________________________ svn-ports-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-ports-all To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
State Changed From-To: open->closed Thanks, I have committed Arrigo's fix, which is also in the upstream git.
Am 10.06.2013 14:53, schrieb naddy@FreeBSD.org: > Synopsis: multimedia/vlc, audio/flac: utterly broken since FLAC update > > State-Changed-From-To: open->closed > State-Changed-By: naddy > State-Changed-When: Mon Jun 10 12:52:56 UTC 2013 > State-Changed-Why: > Thanks, I have committed Arrigo's fix, which is also in the upstream git. > > http://www.freebsd.org/cgi/query-pr.cgi?pr=179449 That helped, thank you! I wonder why vlc had built fine, and then failed after the most recent commit to itself and to FLAC...
Matthias Andree: > I wonder why vlc had built fine, and then failed after the most recent > commit to itself and to FLAC... There is a change in 1.3.0's flac.pc that causes pkg-config --cflags to produce a different result. The idea was always that applications should include FLAC's headers like this #include <FLAC/xxx.h> as in the examples and other Xiph code. However, the old pkg-config specs returned -I/usr/local/include/FLAC, so if you relied on pkg-config and didn't run into an assert.h clash, then plain <xxx.h> also worked. This was corrected in 1.3.0: $ pkg-config --cflags flac -I/usr/local/include Although FLAC 1.3.0 is the first release after almost six years, and the use of symbol visibility has caused a lot of superficial differences in the libraries, there haven't been any significant changes in the documented API. -- Christian "naddy" Weisgerber naddy@mips.inka.de