Bug 179519 - [patch] net/tightvnc pulling in extra dependency
Summary: [patch] net/tightvnc pulling in extra dependency
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Ion-Mihai "IOnut" Tetcu
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-12 16:40 UTC by Kenta Suzumoto
Modified: 2013-07-27 17:00 UTC (History)
0 users

See Also:


Attachments
file.diff (272 bytes, patch)
2013-06-12 16:40 UTC, Kenta Suzumoto
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kenta Suzumoto 2013-06-12 16:40:01 UTC
The net/tightvnc port currently pulls in lang/gcc from ports, which is really huge and takes forever to build. Despite the last commit from miwi saying "Unbreak build for clang" it's still asking for gcc. The one from base builds it fine, so I think we shouldn't pull in lang/gcc to build it.

Maintainer will probably timeout again.

Fix: Patch attached with submission follows:
Comment 1 Edwin Groothuis freebsd_committer 2013-06-12 16:40:09 UTC
Responsible Changed
From-To: freebsd-ports-bugs->itetcu

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Chris Rees freebsd_committer 2013-07-27 16:54:08 UTC
State Changed
From-To: open->closed

Committed. Thanks!
Comment 3 dfilter service freebsd_committer 2013-07-27 16:54:10 UTC
Author: crees
Date: Sat Jul 27 15:53:56 2013
New Revision: 323793
URL: http://svnweb.freebsd.org/changeset/ports/323793

Log:
  remove GCC requirement
  
  PR:		ports/179519
  Submitted by:	Kenta Suzumoto <kentas@hush.com> (also by 4721 below)
  
  add LICENSE
  remove shared library version from depends
  remove stale comment
  
  PR:		ports/180063
  Submitted by:	4721@hushmail.com
  Approved by:	maintainer timeout (itetcu, 5 weeks)

Modified:
  head/net/tightvnc/Makefile

Modified: head/net/tightvnc/Makefile
==============================================================================
--- head/net/tightvnc/Makefile	Sat Jul 27 15:29:02 2013	(r323792)
+++ head/net/tightvnc/Makefile	Sat Jul 27 15:53:56 2013	(r323793)
@@ -4,28 +4,27 @@
 PORTNAME=	tightvnc
 PORTVERSION=	1.3.10
 PORTREVISION=	3
-CATEGORIES=	net
+CATEGORIES=	net java
 MASTER_SITES=	SF/vnc-tight/TightVNC-unix/${PORTVERSION}
 DISTNAME=	${PORTNAME}-${PORTVERSION}_unixsrc
 
 MAINTAINER=	itetcu@FreeBSD.org
 COMMENT=	Enhanced version of VNC
 
-LIB_DEPENDS=	jpeg.11:${PORTSDIR}/graphics/jpeg
+LICENSE=	GPLv2
+LICENSE_FILE=	${WRKSRC}/LICENCE.TXT
+
+LIB_DEPENDS=	jpeg:${PORTSDIR}/graphics/jpeg
 RUN_DEPENDS=	showrgb:${PORTSDIR}/x11/rgb \
 		xauth:${PORTSDIR}/x11/xauth \
 		xorg-fonts>=7.2:${PORTSDIR}/x11-fonts/xorg-fonts
 
 MAKE_JOBS_UNSAFE=	yes
-
 CONFLICTS=	tridiavnc-[0-9]* vnc-[0-9]*
-
 WRKSRC=		${WRKDIR}/vnc_unixsrc
-
 USES=		imake shebangfix
 SHEBANG_FILES=	vncserver
 CFLAGS+=	-Wno-return-type
-USE_GCC=	yes
 USE_BZIP2=	yes
 USE_PERL5=	yes
 USE_XORG=	xaw
@@ -37,9 +36,6 @@ MAN1=		Xvnc.1 vncviewer.1 vncpasswd.1 vn
 OPTIONS_DEFINE=	JVNC_VIEWER
 JVNC_VIEWER_DESC=	Install Java-based vnc viewer
 
-#.include <bsd.port.pre.mk>
-
-### use me when 5.5, 6.1, 6.2R die or we do impement something in b.p.m
 .include <bsd.port.options.mk>
 
 .if ${PORT_OPTIONS:MJVNC_VIEWER}
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"