Bug 179699 - [PATCH] sysutils/lxterminal: Add license, NLS option and fix, take maintainership
Summary: [PATCH] sysutils/lxterminal: Add license, NLS option and fix, take maintainer...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: William Grzybowski
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-19 02:50 UTC by nemysis
Modified: 2013-06-21 16:20 UTC (History)
1 user (show)

See Also:


Attachments
lxterminal-0.1.11_1.patch (3.24 KB, patch)
2013-06-19 02:50 UTC, nemysis
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description nemysis 2013-06-19 02:50:00 UTC
- Take maintainership
- Remove leading article from COMMENT
- Add license (GPLv2)
- Add docs
- Add NLS Option
- Fix NLS
- Trim pkg-plist

Generated and tested manually, tested with port test and with RedPorts, sent with FreeBSD Port Tools 0.99_7 (mode: change, diff: ports)

How-To-Repeat: 
Build log

https://redports.org/buildarchive/20130619004500-47427/
Comment 1 William Grzybowski freebsd_committer 2013-06-21 14:01:33 UTC
Responsible Changed
From-To: freebsd-ports-bugs->wg

I'll take it.
Comment 2 William Grzybowski 2013-06-21 14:11:29 UTC
The patch does not apply cleanly, please take a look.

Thanks

--
William Grzybowski
------------------------------------------
Curitiba/PR - Brasil
Comment 3 dfilter service freebsd_committer 2013-06-21 16:14:13 UTC
Author: wg
Date: Fri Jun 21 15:14:00 2013
New Revision: 321474
URL: http://svnweb.freebsd.org/changeset/ports/321474

Log:
  sysutils/lxterminal: minor fixes
  
  - Add LICENSE (GPLv2) [1]
  - Remove leading article from COMMENT [1]
  - Fix NLS option [1]
  - Install docs [1]
  - Add DOCS option
  - Remove lib ABI from LIB_DEPENDS
  - Pass maintainership to submitter
  
  PR:		ports/179699
  Submitted by:	nemysis <nemysis@gmx.ch>

Modified:
  head/sysutils/lxterminal/Makefile
  head/sysutils/lxterminal/pkg-plist

Modified: head/sysutils/lxterminal/Makefile
==============================================================================
--- head/sysutils/lxterminal/Makefile	Fri Jun 21 14:03:48 2013	(r321473)
+++ head/sysutils/lxterminal/Makefile	Fri Jun 21 15:14:00 2013	(r321474)
@@ -5,21 +5,28 @@ PORTNAME=	lxterminal
 PORTVERSION=	0.1.11
 PORTREVISION=	1
 CATEGORIES=	sysutils
-MASTER_SITES=	SF/lxde/LXTerminal%20%28terminal%20emulator%29/LXTerminal%20${PORTVERSION}
+MASTER_SITES=	SF/lxde/LXTerminal%20%28terminal%20emulator%29/LXTerminal%20${PORTVERSION}/
 
-MAINTAINER=	ports@FreeBSD.org
-COMMENT=	A lightweight terminal emulator from the LXDE project
+MAINTAINER=	nemysis@gmx.ch
+COMMENT=	Lightweight terminal emulator from the LXDE project
 
-LIB_DEPENDS=	vte.9:${PORTSDIR}/x11-toolkits/vte
+LICENSE=	GPLv2
+
+LIB_DEPENDS=	vte:${PORTSDIR}/x11-toolkits/vte
 
-USE_GNOME=	gtk20 intlhack
-USE_GMAKE=	yes
 USES=		iconv
+USE_GNOME=	gtk20 intlhack
 GNU_CONFIGURE=	yes
-USE_LDCONFIG=	yes
 CONFIGURE_ARGS=	--prefix=${PREFIX}
+USE_GMAKE=	yes
+USE_LDCONFIG=	yes
+
 MAN1=		lxterminal.1
 
+PORTDOCS=	AUTHORS README
+
+OPTIONS_DEFINE=	DOCS NLS
+
 .include <bsd.port.options.mk>
 
 .if ${PORT_OPTIONS:MNLS}
@@ -28,8 +35,19 @@ PLIST_SUB+=	NLS=""
 CPPFLAGS+=	-I${LOCALBASE}/include
 LDFLAGS+=	-L${LOCALBASE}/lib
 .else
-CONFIGURE_ARGS+=--disable-nls
 PLIST_SUB+=	NLS="@comment "
 .endif
 
+post-patch:
+.if ! ${PORT_OPTIONS:MNLS}
+	@${REINPLACE_CMD} -e 's|src po|src|' \
+		${WRKSRC}/Makefile.in
+.endif
+
+post-install:
+.if ${PORT_OPTIONS:MDOCS}
+	@${MKDIR} ${DOCSDIR}
+	${INSTALL_DATA} ${PORTDOCS:S|^|${WRKSRC}/|} ${DOCSDIR}
+.endif
+
 .include <bsd.port.mk>

Modified: head/sysutils/lxterminal/pkg-plist
==============================================================================
--- head/sysutils/lxterminal/pkg-plist	Fri Jun 21 14:03:48 2013	(r321473)
+++ head/sysutils/lxterminal/pkg-plist	Fri Jun 21 15:14:00 2013	(r321474)
@@ -1,4 +1,5 @@
 bin/lxterminal
+share/applications/lxterminal.desktop
 %%NLS%%share/locale/af/LC_MESSAGES/lxterminal.mo
 %%NLS%%share/locale/ar/LC_MESSAGES/lxterminal.mo
 %%NLS%%share/locale/be/LC_MESSAGES/lxterminal.mo
@@ -56,25 +57,18 @@ bin/lxterminal
 %%NLS%%share/locale/vi/LC_MESSAGES/lxterminal.mo
 %%NLS%%share/locale/zh_CN/LC_MESSAGES/lxterminal.mo
 %%NLS%%share/locale/zh_TW/LC_MESSAGES/lxterminal.mo
-share/applications/lxterminal.desktop
+%%DATADIR%%/lxterminal-preferences.ui
+%%DATADIR%%/lxterminal.conf
 share/pixmaps/lxterminal.png
-share/lxterminal/lxterminal.conf
-share/lxterminal/lxterminal-preferences.ui
-@dirrm share/lxterminal
+@dirrm %%DATADIR%%
 @dirrmtry share/applications
-%%NLS%%@dirrmtry share/locale/es_VE/LC_MESSAGES
-%%NLS%%@dirrmtry share/locale/es_VE
-%%NLS%%@dirrmtry share/locale/fo/LC_MESSAGES
-%%NLS%%@dirrmtry share/locale/fo
-%%NLS%%@dirrmtry share/locale/frp/LC_MESSAGES
-%%NLS%%@dirrmtry share/locale/frp
-%%NLS%%@dirrmtry share/locale/lg/LC_MESSAGES
-%%NLS%%@dirrmtry share/locale/lg
-%%NLS%%@dirrmtry share/locale/sr@latin/LC_MESSAGES
-%%NLS%%@dirrmtry share/locale/sr@latin
-%%NLS%%@dirrmtry share/locale/te/LC_MESSAGES
-%%NLS%%@dirrmtry share/locale/te
-%%NLS%%@dirrmtry share/locale/tt_RU/LC_MESSAGES
-%%NLS%%@dirrmtry share/locale/tt_RU
 %%NLS%%@dirrmtry share/locale/ur_PK/LC_MESSAGES
 %%NLS%%@dirrmtry share/locale/ur_PK
+%%NLS%%@dirrmtry share/locale/tt_RU/LC_MESSAGES
+%%NLS%%@dirrmtry share/locale/tt_RU
+%%NLS%%@dirrmtry share/locale/lg/LC_MESSAGES
+%%NLS%%@dirrmtry share/locale/lg
+%%NLS%%@dirrmtry share/locale/frp/LC_MESSAGES
+%%NLS%%@dirrmtry share/locale/frp
+%%NLS%%@dirrmtry share/locale/es_VE/LC_MESSAGES
+%%NLS%%@dirrmtry share/locale/es_VE
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 4 William Grzybowski freebsd_committer 2013-06-21 16:14:35 UTC
State Changed
From-To: open->closed

Committed. Thanks!