Bug 179796 - [PATCH] sysutils/lxtask: Add license, docs, fix NLS, take maintainership
Summary: [PATCH] sysutils/lxtask: Add license, docs, fix NLS, take maintainership
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: William Grzybowski
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-21 01:30 UTC by nemysis
Modified: 2013-06-21 15:01 UTC (History)
1 user (show)

See Also:


Attachments
lxtask-0.1.4_1.patch (2.85 KB, patch)
2013-06-21 01:30 UTC, nemysis
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description nemysis 2013-06-21 01:30:00 UTC
- Take maintainership
- Add license (GPLv2)
- Add docs
- Add DOCS NLS Options
- Fix NLS
- Trim pkg-descr
- Trim pkg-message

Generated and tested manually, tested with port test and with RedPorts, sent with FreeBSD Port Tools 0.99_7 (mode: change, diff: ports)

Build log

https://redports.org/buildarchive/20130621001600-27749/
Comment 1 William Grzybowski freebsd_committer 2013-06-21 13:38:28 UTC
Responsible Changed
From-To: freebsd-ports-bugs->wg

I'll take it.
Comment 2 dfilter service freebsd_committer 2013-06-21 14:59:33 UTC
Author: wg
Date: Fri Jun 21 13:59:25 2013
New Revision: 321472
URL: http://svnweb.freebsd.org/changeset/ports/321472

Log:
  sysutils/lxtask: minor fixes
  
  - Add LICENSE (GPLv2)
  - Install docs
  - Fix NLS option
  - Rework pkg-descr to be more verbose
  - Give an example for linprocfs in pkg-message
  - Pass maintainership to submitter
  
  PR:		ports/179796
  Submitted by:	nemysis <nemysis@gmx.ch>

Modified:
  head/sysutils/lxtask/Makefile
  head/sysutils/lxtask/pkg-descr
  head/sysutils/lxtask/pkg-message

Modified: head/sysutils/lxtask/Makefile
==============================================================================
--- head/sysutils/lxtask/Makefile	Fri Jun 21 13:29:08 2013	(r321471)
+++ head/sysutils/lxtask/Makefile	Fri Jun 21 13:59:25 2013	(r321472)
@@ -5,30 +5,47 @@ PORTNAME=	lxtask
 PORTVERSION=	0.1.4
 PORTREVISION=	1
 CATEGORIES=	sysutils gnome
-MASTER_SITES=	SF/lxde/LXTask%20%28task%20manager%29/LXTask%20${PORTVERSION}
+MASTER_SITES=	SF/lxde/LXTask%20%28task%20manager%29/LXTask%20${PORTVERSION}/
 
-MAINTAINER=	ports@FreeBSD.org
+MAINTAINER=	nemysis@gmx.ch
 COMMENT=	Lightweight desktop-independent task manager
 
-USE_GNOME=	gtk20 intlhack
-USE_GMAKE=	yes
+LICENSE=	GPLv2
+
 USES=		iconv
+USE_GNOME=	gtk20 intlhack
 GNU_CONFIGURE=	yes
+USE_GMAKE=	yes
 USE_LDCONFIG=	yes
 
+PORTDOCS=	AUTHORS README TODO
+
+OPTIONS_DEFINE=	DOCS NLS
+OPTIONS_SUB=	yes
+
+NLS_USES=	gettext
+
 .include <bsd.port.options.mk>
 
 .if ${PORT_OPTIONS:MNLS}
-USES+=		gettext
-PLIST_SUB+=	NLS=""
 CPPFLAGS+=	-I${LOCALBASE}/include
 LDFLAGS+=	-L${LOCALBASE}/lib
-.else
-CONFIGURE_ARGS+=--disable-nls
-PLIST_SUB+=	NLS="@comment "
+.endif
+
+post-patch:
+.if ! ${PORT_OPTIONS:MNLS}
+	@${REINPLACE_CMD} -e 's|po src|src|' \
+		${WRKSRC}/Makefile.in
 .endif
 
 post-install:
+.if ${PORT_OPTIONS:MDOCS}
+	@${MKDIR} ${DOCSDIR}
+	${INSTALL_DATA} ${PORTDOCS:S|^|${WRKSRC}/|} ${DOCSDIR}
+.endif
+
+	@${ECHO_CMD}
 	@${CAT} ${PKGMESSAGE}
+	@${ECHO_CMD}
 
 .include <bsd.port.mk>

Modified: head/sysutils/lxtask/pkg-descr
==============================================================================
--- head/sysutils/lxtask/pkg-descr	Fri Jun 21 13:29:08 2013	(r321471)
+++ head/sysutils/lxtask/pkg-descr	Fri Jun 21 13:59:25 2013	(r321472)
@@ -1,3 +1,5 @@
-lxtask is a lightweight desktop-independent task manager.
+LXTask - lightweight and desktop-independent task manager derived from
+xfce4-taskmanager with all dependencies on xfce removed, new features,
+and some improvement of the user interface.
 
 WWW: http://lxde.sourceforge.net/

Modified: head/sysutils/lxtask/pkg-message
==============================================================================
--- head/sysutils/lxtask/pkg-message	Fri Jun 21 13:29:08 2013	(r321471)
+++ head/sysutils/lxtask/pkg-message	Fri Jun 21 13:59:25 2013	(r321472)
@@ -1,4 +1,14 @@
-******************************************************
-This ports works only if linprocfs is mounted. Ensure
-that linprocfs is mounted before running. 
-*****************************************************
+################################################################################
+
+This program will attempt to obtain some system information by accessing files
+in linprocfs. You must mount linprocfs filesystem for this to work correctly.
+This can be accomplished by adding the following line to your /etc/fstab file:
+
+# Device                Mountpoint              FStype          Options Dump Pass
+linprocfs               /compat/linux/proc      linprocfs       rw      0       0
+
+and then, as root, executing the command:
+
+mount linprocfs
+
+################################################################################
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 3 William Grzybowski freebsd_committer 2013-06-21 15:01:03 UTC
State Changed
From-To: open->closed

Committed, with minor changes. Thanks!