Bug 179825 - [PATCH] graphics/gpicview: update to 0.2.3, add license, docs, NLS
Summary: [PATCH] graphics/gpicview: update to 0.2.3, add license, docs, NLS
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Pawel Pekala
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-22 01:30 UTC by nemysis
Modified: 2013-07-14 21:50 UTC (History)
1 user (show)

See Also:


Attachments
gpicview-0.2.3.patch (5.00 KB, patch)
2013-06-22 01:30 UTC, nemysis
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description nemysis 2013-06-22 01:30:00 UTC
- Update to 0.2.3
- Remove leading article from COMMENT
- Add license (GPLv2)
- Add desktop dependency
- Add DOCS NLS Option
- Trim WWW
- Trim pkg-plist

Port maintainer (jmohacsi@bsd.hu) is cc'd.

Generated and tested manually, tested with port test and with RedPorts, sent with FreeBSD Port Tools 0.99_7 (mode: update, diff: ports)

How-To-Repeat: 
Build log

https://redports.org/buildarchive/20130621203200-41583/
Comment 1 Edwin Groothuis freebsd_committer 2013-06-22 01:30:08 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 2 Edwin Groothuis freebsd_committer 2013-06-22 01:30:08 UTC
Maintainer of graphics/gpicview,

Please note that PR ports/179825 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/179825

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 3 Pawel Pekala freebsd_committer 2013-07-14 21:31:20 UTC
Responsible Changed
From-To: freebsd-ports-bugs->pawel

I'll take it.
Comment 4 dfilter service freebsd_committer 2013-07-14 21:46:56 UTC
Author: pawel
Date: Sun Jul 14 20:46:48 2013
New Revision: 323002
URL: http://svnweb.freebsd.org/changeset/ports/323002

Log:
  - Update to 0.2.3
  - Remove leading article from COMMENT
  - Add license (GPLv2)
  - Add desktop dependency
  - Add DOCS NLS Option
  - Trim WWW
  - Trim pkg-plist
  
  PR:		ports/179825
  Submitted by:	nemysis <nemysis@gmx.ch>
  Approved by:	maintainer timeout

Modified:
  head/graphics/gpicview/Makefile
  head/graphics/gpicview/distinfo   (contents, props changed)
  head/graphics/gpicview/pkg-descr   (contents, props changed)
  head/graphics/gpicview/pkg-plist   (contents, props changed)

Modified: head/graphics/gpicview/Makefile
==============================================================================
--- head/graphics/gpicview/Makefile	Sun Jul 14 20:38:13 2013	(r323001)
+++ head/graphics/gpicview/Makefile	Sun Jul 14 20:46:48 2013	(r323002)
@@ -2,28 +2,40 @@
 # $FreeBSD$
 
 PORTNAME=	gpicview
-PORTVERSION=	0.2.1
-PORTREVISION=	4
+PORTVERSION=	0.2.3
 CATEGORIES=	graphics
-MASTER_SITES=	SF/lxde/GPicView%20%28image%20Viewer%29/GPicView%20${PORTVERSION}
+MASTER_SITES=	SF/lxde/GPicView%20%28image%20Viewer%29/GpicView%20${PORTVERSION}/
 
 MAINTAINER=	jmohacsi@bsd.hu
-COMMENT=	A Simple and Fast Image Viewer for X
+COMMENT=	Simple and Fast Image Viewer for X
 
+LICENSE=	GPLv2
+
+USES=		desktop-file-utils gmake
 USE_GNOME=	gtk20
-USE_GMAKE=	yes
 GNU_CONFIGURE=	yes
 CONFIGURE_ARGS=	CPPFLAGS="-I${LOCALBASE}/include" \
 		LDFLAGS="-L${LOCALBASE}/lib"
 
+PORTDOCS=	AUTHORS
+
+OPTIONS_DEFINE=	DOCS NLS
+OPTIONS_SUB=	yes
+
+NLS_USES=	gettext
+
 .include <bsd.port.options.mk>
 
-.if ${PORT_OPTIONS:MNLS}
-USES+=		gettext
-PLIST_SUB+=	NLS=""
-.else
-CONFIGURE_ARGS+=--disable-nls
-PLIST_SUB+=	NLS="@comment "
+post-patch:
+.if ! ${PORT_OPTIONS:MNLS}
+	@${REINPLACE_CMD} -e 's|src po|src|' \
+		${WRKSRC}/Makefile.in
+.endif
+
+post-install:
+.if ${PORT_OPTIONS:MDOCS}
+	@${MKDIR} ${DOCSDIR}
+	${INSTALL_DATA} ${PORTDOCS:S|^|${WRKSRC}/|} ${DOCSDIR}
 .endif
 
 .include <bsd.port.mk>

Modified: head/graphics/gpicview/distinfo
==============================================================================
--- head/graphics/gpicview/distinfo	Sun Jul 14 20:38:13 2013	(r323001)
+++ head/graphics/gpicview/distinfo	Sun Jul 14 20:46:48 2013	(r323002)
@@ -1,2 +1,2 @@
-SHA256 (gpicview-0.2.1.tar.gz) = 4c85ef5affba0812b22426217871cc18366fa570e195dc43a5e0f17fbc005639
-SIZE (gpicview-0.2.1.tar.gz) = 422527
+SHA256 (gpicview-0.2.3.tar.gz) = 58dcdf9e1f29c38c9c5716215981c62c054282a765c57d9f7713232800f3bb99
+SIZE (gpicview-0.2.3.tar.gz) = 478447

Modified: head/graphics/gpicview/pkg-descr
==============================================================================
--- head/graphics/gpicview/pkg-descr	Sun Jul 14 20:38:13 2013	(r323001)
+++ head/graphics/gpicview/pkg-descr	Sun Jul 14 20:46:48 2013	(r323002)
@@ -9,4 +9,4 @@ Features:
     * Open source, licensed under GNU GPL
 
 
-WWW:	http://lxde.sourceforge.net/gpicview/
+WWW: http://lxde.sourceforge.net/gpicview/

Modified: head/graphics/gpicview/pkg-plist
==============================================================================
--- head/graphics/gpicview/pkg-plist	Sun Jul 14 20:38:13 2013	(r323001)
+++ head/graphics/gpicview/pkg-plist	Sun Jul 14 20:46:48 2013	(r323002)
@@ -1,17 +1,30 @@
 bin/gpicview
 share/applications/gpicview.desktop
+%%DATADIR%%/pixmaps/object-flip-horizontal.png
+%%DATADIR%%/pixmaps/object-flip-vertical.png
+%%DATADIR%%/pixmaps/object-rotate-left.png
+%%DATADIR%%/pixmaps/object-rotate-right.png
+%%DATADIR%%/ui/pref-dlg.ui
 %%NLS%%share/locale/af/LC_MESSAGES/gpicview.mo
 %%NLS%%share/locale/ar/LC_MESSAGES/gpicview.mo
+%%NLS%%share/locale/bg/LC_MESSAGES/gpicview.mo
+%%NLS%%share/locale/bn/LC_MESSAGES/gpicview.mo
+%%NLS%%share/locale/bn_IN/LC_MESSAGES/gpicview.mo
+%%NLS%%share/locale/ca/LC_MESSAGES/gpicview.mo
 %%NLS%%share/locale/cs/LC_MESSAGES/gpicview.mo
 %%NLS%%share/locale/da/LC_MESSAGES/gpicview.mo
 %%NLS%%share/locale/de/LC_MESSAGES/gpicview.mo
+%%NLS%%share/locale/el/LC_MESSAGES/gpicview.mo
 %%NLS%%share/locale/es/LC_MESSAGES/gpicview.mo
+%%NLS%%share/locale/es_VE/LC_MESSAGES/gpicview.mo
 %%NLS%%share/locale/et/LC_MESSAGES/gpicview.mo
 %%NLS%%share/locale/eu/LC_MESSAGES/gpicview.mo
 %%NLS%%share/locale/fa/LC_MESSAGES/gpicview.mo
 %%NLS%%share/locale/fi/LC_MESSAGES/gpicview.mo
 %%NLS%%share/locale/fr/LC_MESSAGES/gpicview.mo
+%%NLS%%share/locale/frp/LC_MESSAGES/gpicview.mo
 %%NLS%%share/locale/gl/LC_MESSAGES/gpicview.mo
+%%NLS%%share/locale/he/LC_MESSAGES/gpicview.mo
 %%NLS%%share/locale/hr/LC_MESSAGES/gpicview.mo
 %%NLS%%share/locale/hu/LC_MESSAGES/gpicview.mo
 %%NLS%%share/locale/id/LC_MESSAGES/gpicview.mo
@@ -31,7 +44,9 @@ share/applications/gpicview.desktop
 %%NLS%%share/locale/ru/LC_MESSAGES/gpicview.mo
 %%NLS%%share/locale/sk/LC_MESSAGES/gpicview.mo
 %%NLS%%share/locale/sl/LC_MESSAGES/gpicview.mo
+%%NLS%%share/locale/sr/LC_MESSAGES/gpicview.mo
 %%NLS%%share/locale/sv/LC_MESSAGES/gpicview.mo
+%%NLS%%share/locale/th/LC_MESSAGES/gpicview.mo
 %%NLS%%share/locale/tr/LC_MESSAGES/gpicview.mo
 %%NLS%%share/locale/uk/LC_MESSAGES/gpicview.mo
 %%NLS%%share/locale/ur/LC_MESSAGES/gpicview.mo
@@ -39,15 +54,14 @@ share/applications/gpicview.desktop
 %%NLS%%share/locale/vi/LC_MESSAGES/gpicview.mo
 %%NLS%%share/locale/zh_CN/LC_MESSAGES/gpicview.mo
 %%NLS%%share/locale/zh_TW/LC_MESSAGES/gpicview.mo
-%%DATADIR%%/pixmaps/object-rotate-right.png
-%%DATADIR%%/pixmaps/object-rotate-left.png
-%%DATADIR%%/pixmaps/object-flip-horizontal.png
-%%DATADIR%%/pixmaps/object-flip-vertical.png
-%%DATADIR%%/ui/pref-dlg.ui
 share/pixmaps/gpicview.png
-@dirrm %%DATADIR%%/pixmaps
-@dirrm %%DATADIR%%/ui
-@dirrmtry share/applications
-@dirrm %%DATADIR%%
 %%NLS%%@dirrmtry share/locale/ur_PK/LC_MESSAGES
 %%NLS%%@dirrmtry share/locale/ur_PK
+%%NLS%%@dirrmtry share/locale/frp/LC_MESSAGES
+%%NLS%%@dirrmtry share/locale/frp
+%%NLS%%@dirrmtry share/locale/es_VE/LC_MESSAGES
+%%NLS%%@dirrmtry share/locale/es_VE
+@dirrm %%DATADIR%%/ui
+@dirrm %%DATADIR%%/pixmaps
+@dirrm %%DATADIR%%
+@dirrmtry share/applications
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 5 Pawel Pekala freebsd_committer 2013-07-14 21:47:06 UTC
State Changed
From-To: feedback->closed

Committed, with minor changes. Thanks!