Bug 180004 - [ patch ] lang/gawk: unrecorded dependency
Summary: [ patch ] lang/gawk: unrecorded dependency
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Johan van Selst
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-26 16:00 UTC by Dan Lukes
Modified: 2013-06-29 10:40 UTC (History)
0 users

See Also:


Attachments
patch-gawk (554 bytes, text/plain)
2013-06-26 16:00 UTC, Dan Lukes
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Dan Lukes 2013-06-26 16:00:00 UTC
	if math/mpfr and math/gmp are present at th etime of gawk compilation
        then they are detected by configure and linked to gawk
	such dependency is not recorded, so package installed
	on other system without mfpr&gmp will not start

Fix: gawk should not be linked against mpfr&gmp unless requested
	by administrator. 
	Dependencies need to be properly recorded in such case.

	See patch bellow
How-To-Repeat: 	compile lang/gawk on system with math/mpfr & math/gmp present
	then deinstall math/mpfr & math/gmp
	then try to run gawk
Comment 1 Edwin Groothuis freebsd_committer 2013-06-26 16:00:08 UTC
Responsible Changed
From-To: freebsd-ports-bugs->johans

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Johan van Selst freebsd_committer 2013-06-29 10:30:34 UTC
State Changed
From-To: open->closed

Committed, thanks.
Comment 3 dfilter service freebsd_committer 2013-06-29 10:30:35 UTC
Author: johans
Date: Sat Jun 29 09:30:23 2013
New Revision: 322035
URL: http://svnweb.freebsd.org/changeset/ports/322035

Log:
  - Make optional dependency on libmpfr explicit in GNU awk
    This adds support for multiple-precision floating-point computation
  
  PR:		ports/180004
  Submitted by:	Dan Lukes <dan@obluda.cz>

Modified:
  head/lang/gawk/Makefile

Modified: head/lang/gawk/Makefile
==============================================================================
--- head/lang/gawk/Makefile	Sat Jun 29 09:25:14 2013	(r322034)
+++ head/lang/gawk/Makefile	Sat Jun 29 09:30:23 2013	(r322035)
@@ -11,6 +11,9 @@ COMMENT=	The GNU version of Awk
 
 LIB_DEPENDS=	sigsegv:${PORTSDIR}/devel/libsigsegv
 
+OPTIONS_DEFINE=	MPFR
+MPFR_DESC?=	Support multiple-precision floating-point computation
+
 INFO=		gawk gawkinet
 
 USE_XZ=		true
@@ -35,6 +38,12 @@ CONFIGURE_ARGS+=--disable-nls
 PLIST_SUB+=	NLS="@comment "
 .endif
 
+.if ${PORT_OPTIONS:MMPFR}
+LIB_DEPENDS=	mpfr:${PORTSDIR}/math/mpfr
+.else
+CONFIGURE_ARGS+=--without-gmp --without-mpfr
+.endif
+
 post-patch:
 	@${RM} -f ${WRKSRC}/doc/*.info
 	@${REINPLACE_CMD} -e 's/ -export-dynamic/ -Wl,--export-dynamic/' \
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"