Bug 180169 - graphics/freeimage install wrong links
Summary: graphics/freeimage install wrong links
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Pietro Cerutti
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-07-01 14:20 UTC by ml
Modified: 2013-07-08 16:10 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description ml 2013-07-01 14:20:00 UTC
I first found out about this via portsclean:

#portsclean -L
..
Unreadable file or directory: /usr/local/lib/libfreeimageplus.so.3
Unreadable file or directory: /usr/local/lib/libfreeimageplus.so

So:
ls -l /usr/local/lib|grep freeimage
-rwxr-xr-x   1 root  wheel   3529452 Jul  1 15:02 libfreeimage-3.15.4.so
-rw-r--r--   1 root  wheel   4917684 Jul  1 15:02 libfreeimage.a
lrwxr-xr-x   1 root  wheel        17 Jul  1 15:02 libfreeimage.so -> libfreeimage.so.3
lrwxr-xr-x   1 root  wheel        22 Jul  1 15:02 libfreeimage.so.3 -> libfreeimage-3.15.4.so
-rwxr-xr-x   1 root  wheel   3566560 Jul  1 15:02 libfreeimageplus-3.15.4.so
-rw-r--r--   1 root  wheel   4988200 Jul  1 15:02 libfreeimageplus.a
lrwxr-xr-x   1 root  wheel        23 Jul  1 15:02 libfreeimageplus.so -> libfreeimageplus-3.15.4
lrwxr-xr-x   1 root  wheel        23 Jul  1 15:02 libfreeimageplus.so.3 -> libfreeimageplus-3.15.4

The last two links point to a nonexistent file.



cd /usr/ports/graphics/freeimage ; make install
..
install -m 755 -o root -g wheel libfreeimageplus-3.15.4.so //usr/local/lib
/bin/ln -s libfreeimageplus-3.15.4 /usr/local/lib/libfreeimageplus.so.3
/bin/ln -s libfreeimageplus-3.15.4 /usr/local/lib/libfreeimageplus.so
===>   Running ldconfig
..


So are the last lines in Makefile wrong?
${LN} -s libfreeimageplus-${PORTVERSION} ${PREFIX}/lib/libfreeimageplus.so.3
${LN} -s libfreeimageplus-${PORTVERSION} ${PREFIX}/lib/libfreeimageplus.so

Fix: 

Perhaps the last lines in Makefile should be:
${LN} -s libfreeimageplus-${PORTVERSION}.so ${PREFIX}/lib/libfreeimageplus.so.3
${LN} -s libfreeimageplus-${PORTVERSION}.so ${PREFIX}/lib/libfreeimageplus.so
Comment 1 Edwin Groothuis freebsd_committer 2013-07-01 14:20:07 UTC
Responsible Changed
From-To: freebsd-ports-bugs->gahr

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer 2013-07-08 16:01:58 UTC
Author: gahr
Date: Mon Jul  8 15:01:51 2013
New Revision: 322509
URL: http://svnweb.freebsd.org/changeset/ports/322509

Log:
  - Fix shlib symlinks
  - Bump PORTREVISION
  
  PR:		180169
  Submitted by:	Andrea Venturoli <ml@netfence.it>

Modified:
  head/graphics/freeimage/Makefile

Modified: head/graphics/freeimage/Makefile
==============================================================================
--- head/graphics/freeimage/Makefile	Mon Jul  8 14:31:35 2013	(r322508)
+++ head/graphics/freeimage/Makefile	Mon Jul  8 15:01:51 2013	(r322509)
@@ -3,7 +3,7 @@
 
 PORTNAME=	freeimage
 PORTVERSION=	3.15.4
-PORTREVISION=	1
+PORTREVISION=	2
 CATEGORIES=	graphics
 MASTER_SITES=	SF/${PORTNAME}/Source%20Distribution/${PORTVERSION}
 DISTNAME=	FreeImage${PORTVERSION:S/.//g}
@@ -45,7 +45,7 @@ post-build:
 
 post-install:
 	cd ${WRKSRC} && ${GMAKE} -f Makefile.fip ${INSTALL_TARGET}
-	${LN} -s libfreeimageplus-${PORTVERSION} ${PREFIX}/lib/libfreeimageplus.so.3
-	${LN} -s libfreeimageplus-${PORTVERSION} ${PREFIX}/lib/libfreeimageplus.so
+	${LN} -s libfreeimageplus-${PORTVERSION}.so.3 ${PREFIX}/lib/libfreeimageplus.so
+	${LN} -s libfreeimageplus-${PORTVERSION}.so ${PREFIX}/lib/libfreeimageplus.so.3
 
 .include <bsd.port.post.mk>
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 3 Pietro Cerutti freebsd_committer 2013-07-08 16:02:15 UTC
State Changed
From-To: open->closed

Committed, with minor changes. Thanks!