Bug 180257 - [patch] devel/gdb: add USE_CSTD=gnu89 for clang
[patch] devel/gdb: add USE_CSTD=gnu89 for clang
Status: Closed FIXED
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s)
Latest
Any Any
: Normal Affects Only Me
Assigned To: Tijl Coosemans
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-07-04 14:50 UTC by Tijl Coosemans
Modified: 2013-07-06 13:13 UTC (History)
0 users

See Also:


Attachments
gdb.patch (1.90 KB, patch)
2013-07-04 14:50 UTC, Tijl Coosemans
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tijl Coosemans freebsd_committer 2013-07-04 14:50:00 UTC
Problems with inline and clang are because clang defaults to C99.
By adding USE_CSTD=gnu89 patch-include-cgen-basic-ops.h can be removed.
Comment 1 Edwin Groothuis freebsd_committer 2013-07-04 14:50:08 UTC
Responsible Changed
From-To: freebsd-ports-bugs->miwi

miwi@ wants this submitter's PRs (via the GNATS Auto Assign Tool)
Comment 2 Edwin Groothuis freebsd_committer 2013-07-04 14:50:09 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Edwin Groothuis freebsd_committer 2013-07-04 14:50:09 UTC
Maintainer of devel/gdb,

Please note that PR ports/180257 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/180257

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 4 Tijl Coosemans freebsd_committer 2013-07-04 20:28:00 UTC
Responsible Changed
From-To: miwi->tijl

Take my own PR.
Comment 5 luca.pizzamiglio 2013-07-06 11:34:05 UTC
Definitively approved!

Thanks a lot

Best regards,
Luca
Comment 6 dfilter freebsd_committer 2013-07-06 13:07:49 UTC
Author: tijl
Date: Sat Jul  6 12:07:36 2013
New Revision: 322388
URL: http://svnweb.freebsd.org/changeset/ports/322388

Log:
  Problems with inline and clang are because clang defaults to C99.
  By adding USE_CSTD=gnu89 patch-include-cgen-basic-ops.h can be removed.
  
  PR:		180257
  Approved by:	luca.pizzamiglio@gmail.com (maintainer)

Deleted:
  head/devel/gdb/files/patch-include-cgen-basic-ops.h
Modified:
  head/devel/gdb/Makefile

Modified: head/devel/gdb/Makefile
==============================================================================
--- head/devel/gdb/Makefile	Sat Jul  6 11:51:07 2013	(r322387)
+++ head/devel/gdb/Makefile	Sat Jul  6 12:07:36 2013	(r322388)
@@ -13,6 +13,7 @@ COMMENT=	GNU GDB of newer version than c
 LICENSE=	GPLv3
 
 USE_BZIP2=	yes
+USE_CSTD=	gnu89
 USE_GMAKE=	yes
 USES=		iconv
 GNU_CONFIGURE=	yes
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 7 Tijl Coosemans freebsd_committer 2013-07-06 13:12:48 UTC
State Changed
From-To: feedback->closed

Committed in r322388.