Bug 180269 - [patch] sysutils/pftop: set CSTD=gnu89
Summary: [patch] sysutils/pftop: set CSTD=gnu89
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Marcelo Araujo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-07-04 17:10 UTC by Tijl Coosemans
Modified: 2013-07-12 06:50 UTC (History)
0 users

See Also:


Attachments
pftop.patch (735 bytes, patch)
2013-07-04 17:10 UTC, Tijl Coosemans
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tijl Coosemans freebsd_committer 2013-07-04 17:10:02 UTC
Problems with inline and clang are because clang defaults to C99.
Instead of patching the code just use C89.
Comment 1 Edwin Groothuis freebsd_committer 2013-07-04 17:10:18 UTC
Responsible Changed
From-To: freebsd-ports-bugs->araujo

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer 2013-07-12 06:41:17 UTC
Author: araujo
Date: Fri Jul 12 05:41:05 2013
New Revision: 322815
URL: http://svnweb.freebsd.org/changeset/ports/322815

Log:
  - Instead of patching the code just use C89 and stop the problems with inline.
  
  PR:		ports/180269
  Submitted by:	tijl@

Modified:
  head/sysutils/pftop/Makefile

Modified: head/sysutils/pftop/Makefile
==============================================================================
--- head/sysutils/pftop/Makefile	Fri Jul 12 05:12:42 2013	(r322814)
+++ head/sysutils/pftop/Makefile	Fri Jul 12 05:41:05 2013	(r322815)
@@ -34,6 +34,7 @@ CFLAGS+=	-DHAVE_FINE_GRAINED_LOCKING=1
 
 EXTRA_PATCHES+=	${FILESDIR}/extra-patch-engine.c
 
+MAKE_ARGS+=	CSTD=gnu89
 MAKE_ENV+=	__MAKE_CONF=/dev/null
 
 PLIST_FILES=	sbin/pftop
@@ -43,7 +44,6 @@ post-patch:
 	    ${WRKSRC}/engine.c
 	@${REINPLACE_CMD} -e 's|__dead|__dead2|g' ${WRKSRC}/sf-gencode.h
 	@${REINPLACE_CMD} -e 's|__dead|__dead2|g' ${WRKSRC}/sf-gencode.c
-	@${REINPLACE_CMD} -e 's|__inline__|static __inline__|g' ${WRKSRC}/pftop.c
 	@${REINPLACE_CMD} -e 's|#include <net/if_pflog.h>||g' \
 	    ${WRKSRC}/sf-gencode.c
 
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 3 Marcelo Araujo freebsd_committer 2013-07-12 06:43:27 UTC
State Changed
From-To: open->closed

Committed. Thanks!