Bug 180459 - Port devel/py-dbus ' wrong PORTDOCS logic and pkg-plist break package [patch]
Summary: Port devel/py-dbus ' wrong PORTDOCS logic and pkg-plist break package [patch]
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-gnome (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-07-11 11:50 UTC by Horia Racoviceanu
Modified: 2016-01-17 10:43 UTC (History)
2 users (show)

See Also:

Attachments
file.diff (1.81 KB, patch)
2013-07-11 11:50 UTC, Horia Racoviceanu 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Horia Racoviceanu 2013-07-11 11:50:00 UTC 
Unsetting HTMLDOCS breaks package from incorrect pkg-plist and logic that prevents PORTDOCS from being installed.

/usr/ports/devel/py-dbus # make deinstall
===>  Deinstalling for devel/py-dbus
===>   Deinstalling py27-dbus-1.1.1
pkg_delete: file '/usr/local/share/doc/py-dbus/API_CHANGES.txt' doesn't exist
pkg_delete: file '/usr/local/share/doc/py-dbus/HACKING.txt' doesn't exist
pkg_delete: file '/usr/local/share/doc/py-dbus/NEWS' doesn't exist
pkg_delete: file '/usr/local/share/doc/py-dbus/PY3PORT.txt' doesn't exist
pkg_delete: file '/usr/local/share/doc/py-dbus/README' doesn't exist
pkg_delete: file '/usr/local/share/doc/py-dbus/tutorial.txt' doesn't exist
pkg_delete: file '/usr/local/share/doc/py-dbus' doesn't exist
pkg_delete: unable to completely remove directory '/usr/local/share/doc/py-dbus'
pkg_delete: couldn't entirely delete package `py27-dbus-1.1.1'
(perhaps the packing list is incorrectly specified?)

Furthermore, pkg-plist has incorrect values which break "make package" even when HTMLDOCS is set.

===>   Registering installation for py27-dbus-1.1.1
===>  Building package for py27-dbus-1.1.1
tar: share/doc/py-dbus/TODO.html: Cannot stat: No such file or directory
tar: Error exit delayed from previous errors.
pkg_create: make_dist: tar command failed with code 256
*** [do-package] Error code 1

Buildlog:
https://redports.org/buildarchive/20130710235800-32687/

Mentioned:
http://portsmon.freebsd.org/portoverview.py?category=devel&portname=py-dbus
http://lists.freebsd.org/pipermail/svn-ports-all/2013-July/024211.html

No related information in ports/UPDATING

Fix: Changed Makefile and pkg-plist to handle DOCS properly:

See buildlog
https://redports.org/buildarchive/20130711074301-32666/

See attachment

Patch attached with submission follows:
How-To-Repeat: # make deinstall
# pkg_delete
# make package
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2013-07-11 11:50:09 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->gnome

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Carlo Strub freebsd_committer freebsd_triage 2014-09-14 10:37:34 UTC 
Is this PR still relevant?
Comment 3 Horia Racoviceanu 2014-10-01 20:35:40 UTC 
(In reply to Carlo Strub from comment #2)
> Is this PR still relevant?

Not relevant anymore.
Thank you.