Bug 180617 - [usbdevs] [patch] New quirk (another member of Western Digital My Passport family of devices)
Summary: [usbdevs] [patch] New quirk (another member of Western Digital My Passport fa...
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: usb (show other bugs)
Version: 9.1-RELEASE
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-usb (Nobody)
URL:
Keywords:
: 178771 (view as bug list)
Depends on:
Blocks:
 
Reported: 2013-07-17 21:00 UTC by Dan Lukes
Modified: 2014-12-26 11:26 UTC (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dan Lukes 2013-07-17 21:00:00 UTC
	Quirk UQ_MSC_NO_SYNC_CACHE has been already added to
        WESTERN MYPASSPORD 0x0748 device (see PR usb/178771)

	Same quirk has been requested by Greg Rivers for
	WD My Passport 0x07A8 (same PR, not yet commited)


	I would like to call for same quirk (e.g. UQ_MSC_NO_SYNC_CACHE) for 
	WD My Passport Essential 0x0740

Fix: 

Add 
product WESTERN MYPASSPORTES 0x0740 MyPassport Essential External HDD
	to
sys/dev/usb/usbdevs
	and
USB_QUIRK(WESTERN, MYPASSPORTES, 0x0000, 0xffff, UQ_MSC_NO_SYNC_CACHE)
	to
sys/dev/usb/quirk/usb_quirk.c

Just for the completeness - I would like to sumarize the PID and names 
of WD USB external disks recognized by WD Utilities so product names 
in usbdevs can be selected with possible future additions in the mind

Product Name         | PID
---------------------+--------------------------------------------------
MyPassport           | 0746,0748,074A,074C,074E,07A6,07A8,07AA,07AC,07AE
MyPassport Essential | 070A,071A,0730,0732,0740,0742,0750,0752,07A0,07A2
MyPassport Elite     | 070B
MyPassport Studio    | 070C,071C,071D
MyBook Essential     | 1110,111A,1130,1132,1140,1142,1144,1150,1152,1170,1172
MyBook Elite         | 1111
MyBook Studio        | 1112,111B,111C
MyBook               | 1123
Comment 1 Hans Petter Selasky freebsd_committer freebsd_triage 2014-12-08 10:41:55 UTC
*** Bug 178771 has been marked as a duplicate of this bug. ***
Comment 2 commit-hook freebsd_committer freebsd_triage 2014-12-08 10:42:35 UTC
A commit references this bug:

Author: hselasky
Date: Mon Dec  8 10:41:35 UTC 2014
New revision: 275605
URL: https://svnweb.freebsd.org/changeset/base/275605

Log:
  Add more USB quirks for Western Digital external USB HDD
  enclosures. Rename an incorrectly named device. Increase
  limit for maximum number of quirks.

  PR:	    178771, 180617
  MFC after:  2 weeks

Changes:
  head/sys/dev/usb/quirk/usb_quirk.c
  head/sys/dev/usb/usbdevs
Comment 3 Hans Petter Selasky freebsd_committer freebsd_triage 2014-12-08 10:51:27 UTC
Can you test and verify the submitted patch?

--HPS
Comment 4 Greg Rivers 2014-12-22 04:18:45 UTC
I've just come across another drive in this family:

Western Digital My Passport Ultra, 2TB, Model WDBMWV0020BBK.

$ usbconfig -d 0.2 dump_device_desc
ugen0.2: <My Passport 0741 Western Digital> at usbus0, cfg=0 md=HOST spd=SUPER (5.0Gbps) pwr=ON (224mA)

  bLength = 0x0012 
  bDescriptorType = 0x0001 
  bcdUSB = 0x0300 
  bDeviceClass = 0x0000  <Probed by interface class>
  bDeviceSubClass = 0x0000 
  bDeviceProtocol = 0x0000 
  bMaxPacketSize0 = 0x0009 
  idVendor = 0x1058 
  idProduct = 0x0741 
  bcdDevice = 0x1022 
  iManufacturer = 0x0001  <Western Digital>
  iProduct = 0x0002  <My Passport 0741>
  iSerialNumber = 0x0005  <575836314137334839383938>
  bNumConfigurations = 0x0001

Can you please add this one to your upcoming MFC?  Thanks.
Comment 5 Hans Petter Selasky freebsd_committer freebsd_triage 2014-12-23 16:20:30 UTC
Hi,

Can you append a complete working patch for the new ID and I'll include it in the MFC.

Thank you!

--HPS
Comment 6 commit-hook freebsd_committer freebsd_triage 2014-12-26 10:53:38 UTC
A commit references this bug:

Author: hselasky
Date: Fri Dec 26 10:53:23 UTC 2014
New revision: 276239
URL: https://svnweb.freebsd.org/changeset/base/276239

Log:
  Add more quirks.

  PR:		180617
  MFC after:	1 day

Changes:
  head/sys/dev/usb/quirk/usb_quirk.c
  head/sys/dev/usb/usbdevs
Comment 7 commit-hook freebsd_committer freebsd_triage 2014-12-26 11:17:44 UTC
A commit references this bug:

Author: hselasky
Date: Fri Dec 26 11:17:00 UTC 2014
New revision: 276241
URL: https://svnweb.freebsd.org/changeset/base/276241

Log:
  MFC r259675, r262128, r262129, r275605, r276239 and r276240:
  Add more USB quirks.

  PR:	178771
  PR:	180617
  PR:	195372

Changes:
_U  stable/10/
  stable/10/sys/dev/usb/quirk/usb_quirk.c
  stable/10/sys/dev/usb/usbdevs
Comment 8 commit-hook freebsd_committer freebsd_triage 2014-12-26 11:26:50 UTC
A commit references this bug:

Author: hselasky
Date: Fri Dec 26 11:25:57 UTC 2014
New revision: 276242
URL: https://svnweb.freebsd.org/changeset/base/276242

Log:
  MFC r262128, r262129, r275605, r276239 and r276240:
  Add more USB quirks.

  PR:	178771
  PR:	180617
  PR:	195372

Changes:
_U  stable/9/sys/
_U  stable/9/sys/dev/
  stable/9/sys/dev/usb/quirk/usb_quirk.c
  stable/9/sys/dev/usb/usbdevs