Bug 180623 - [patch] fix display issues in editors/chexedit
Summary: [patch] fix display issues in editors/chexedit
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Dmitry Marakasov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-07-18 05:00 UTC by r4721@tormail.org
Modified: 2013-07-22 18:30 UTC (History)
0 users

See Also:


Attachments
file.diff (1.68 KB, patch)
2013-07-18 05:00 UTC, r4721@tormail.org
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description r4721@tormail.org 2013-07-18 05:00:00 UTC
* remove patch hunk from patch-src-file.c that alters timestamp format. this was apparently to work around some issue in ncurses from freebsd 4 which is no longer present and today causes the timestamps to overflow their field in the directory view.

* add use_default_colors() call to patch-src-init.c to handle some changed default actions in ncurses over the years. this fixes the blank windows that occur with chexedit in some terminal programs like rxvt-unicode when background and foreground are set.

* add LICENSE

Fix: Patch attached with submission follows:
Comment 1 Edwin Groothuis freebsd_committer 2013-07-18 05:00:07 UTC
Responsible Changed
From-To: freebsd-ports-bugs->amdmi3

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer 2013-07-22 18:28:51 UTC
Author: amdmi3
Date: Mon Jul 22 17:28:38 2013
New Revision: 323482
URL: http://svnweb.freebsd.org/changeset/ports/323482

Log:
  - Fix timestamp display in file view
  - Fix colors on some terminals
  - Add LICENSE
  
  PR:		180623
  Submitted by:	"r4721@tormail.org" <r4721@tormail.org>

Modified:
  head/editors/chexedit/Makefile
  head/editors/chexedit/files/patch-src-file.c
  head/editors/chexedit/files/patch-src-init.c

Modified: head/editors/chexedit/Makefile
==============================================================================
--- head/editors/chexedit/Makefile	Mon Jul 22 17:24:50 2013	(r323481)
+++ head/editors/chexedit/Makefile	Mon Jul 22 17:28:38 2013	(r323482)
@@ -12,6 +12,9 @@ DISTNAME=	hexedit-${PORTVERSION}
 MAINTAINER=	amdmi3@FreeBSD.org
 COMMENT=	Full screen text mode Hex editor using the [n]curses library
 
+LICENSE=	GPLv2
+LICENSE_FILE=	${WRKSRC}/COPYING
+
 GNU_CONFIGURE=	yes
 PLIST_FILES=	bin/chexedit
 

Modified: head/editors/chexedit/files/patch-src-file.c
==============================================================================
--- head/editors/chexedit/files/patch-src-file.c	Mon Jul 22 17:24:50 2013	(r323481)
+++ head/editors/chexedit/files/patch-src-file.c	Mon Jul 22 17:28:38 2013	(r323482)
@@ -8,14 +8,3 @@
  #include <grp.h>
  #include <pwd.h>
  
-@@ -618,8 +619,8 @@
- 
-          wprintw (Globals.wmain,
-    /* why does it seem like on OpenBSD this is broken? */
--#if defined(__OpenBSD__) || defined(BROKEN)
--            "%s %-8s %-8s %10ld %1d\b2d-%02d-%02d %02d:%02d ",
-+#if defined(__OpenBSD__) || defined(__FreeBSD__) || defined(BROKEN)
-+            "%s %-8s %-8s %10ld %1d\b%04d-%02d-%02d %02d:%02d ",
- #else
-             "%s %-8s %-8s %10ld %d-%02d-%02d %02d:%02d ",
- #endif

Modified: head/editors/chexedit/files/patch-src-init.c
==============================================================================
--- head/editors/chexedit/files/patch-src-init.c	Mon Jul 22 17:24:50 2013	(r323481)
+++ head/editors/chexedit/files/patch-src-init.c	Mon Jul 22 17:28:38 2013	(r323482)
@@ -12,7 +12,15 @@
  extern char **environ;
  
  
-@@ -463,7 +468,7 @@
+@@ -250,6 +255,7 @@
+    if (color_term != -1)
+    {
+       start_color ();
++      use_default_colors();
+       if ((color_term = has_colors ()))
+       {
+          color_term = 1;
+@@ -463,7 +469,7 @@
        filestat.st_size = DEFAULT_BUFFER_SIZE;
     }
  
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 3 Dmitry Marakasov freebsd_committer 2013-07-22 18:30:25 UTC
State Changed
From-To: open->closed

Committed. Thanks!