Bug 180738 - sysutils/bacula-server fix rcvar in bacula-sd rc.d scripts
Summary: sysutils/bacula-server fix rcvar in bacula-sd rc.d scripts
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Ruslan Makhmatkhanov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-07-22 17:00 UTC by Oleg Ginzburg
Modified: 2013-07-22 19:08 UTC (History)
0 users

See Also:


Attachments
file.diff (755 bytes, patch)
2013-07-22 17:00 UTC, Oleg Ginzburg
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Oleg Ginzburg 2013-07-22 17:00:03 UTC
/usr/ports/sysutils/bacula-server/files/bacula-sd.in have wrong rcvar value. With current setting, fresh install of the bacula-server try to start sd without corresponding params in rc.conf:

# service bacula-sd start
/usr/local/etc/rc.d/bacula-sd: set_rcvar: not found
Starting bacula_sd.
22-Jul 19:49 bacula-sd: ERROR TERMINATION at parse_conf.c:918
Config error: Cannot open config file "/usr/local/etc/bacula/bacula-sd.conf": No such file or directory

/usr/local/etc/rc.d/bacula-sd: WARNING: failed to start bacula_sd

Fix: change to

rcvar=${name}_enable



Patch attached with submission follows:
How-To-Repeat: make -C /usr/ports/sysutils/bacula-server install
service bacula-sd start
Comment 1 Edwin Groothuis freebsd_committer 2013-07-22 17:00:20 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 2 Edwin Groothuis freebsd_committer 2013-07-22 17:00:20 UTC
Maintainer of sysutils/bacula-server,

Please note that PR ports/180738 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/180738

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 3 Dan Langille 2013-07-22 18:17:59 UTC
Maintainer approves.

-- 
Dan Langille - http://langille.org/
Comment 4 Ruslan Makhmatkhanov freebsd_committer 2013-07-22 18:38:05 UTC
Responsible Changed
From-To: freebsd-ports-bugs->rm

I will take it.
Comment 5 dfilter service freebsd_committer 2013-07-22 18:51:51 UTC
Author: rm
Date: Mon Jul 22 17:51:39 2013
New Revision: 323486
URL: http://svnweb.freebsd.org/changeset/ports/323486

Log:
  Fix rc-script for bacula storage daemon. This bug was introduced in r309025
  by yours truly(.
  
  PR:		180738
  Submitted by:	Oleg Ginzburg <olevole@olevole.ru>
  Approved by:	Dan Langille <dan@langille.org> (maintainer)

Modified:
  head/sysutils/bacula-server/Makefile
  head/sysutils/bacula-server/files/bacula-sd.in

Modified: head/sysutils/bacula-server/Makefile
==============================================================================
--- head/sysutils/bacula-server/Makefile	Mon Jul 22 17:43:42 2013	(r323485)
+++ head/sysutils/bacula-server/Makefile	Mon Jul 22 17:51:39 2013	(r323486)
@@ -3,7 +3,7 @@
 
 PORTNAME=	bacula
 DISTVERSION=	5.2.12
-PORTREVISION?=	2
+PORTREVISION?=	3
 CATEGORIES?=	sysutils
 MASTER_SITES=	SF/bacula/bacula/${PORTVERSION}
 PKGNAMEPREFIX?=	#

Modified: head/sysutils/bacula-server/files/bacula-sd.in
==============================================================================
--- head/sysutils/bacula-server/files/bacula-sd.in	Mon Jul 22 17:43:42 2013	(r323485)
+++ head/sysutils/bacula-server/files/bacula-sd.in	Mon Jul 22 17:51:39 2013	(r323486)
@@ -17,7 +17,7 @@
 . /etc/rc.subr
 
 name="bacula_sd"
-rcvar=`set_rcvar`
+rcvar=${name}_enable
 command=%%PREFIX%%/sbin/bacula-sd
 
 load_rc_config $name
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 6 Ruslan Makhmatkhanov freebsd_committer 2013-07-22 19:08:39 UTC
State Changed
From-To: feedback->closed

Committed, thank you!