Bug 181120 - www/apache24 patch places "Include" line in the wrong place
Summary: www/apache24 patch places "Include" line in the wrong place
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-apache (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-07 20:10 UTC by Stephen Wall
Modified: 2013-11-05 23:22 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stephen Wall 2013-08-07 20:10:00 UTC 
apache24/files/patch-docs__conf__httpd.conf.in includes a chunk that in apache22 placed "Include @rel_sysconfdir@/Includes/*.conf" at the end of httpd.conf.in.  It does not place it at the end in apache24, instead placing it before a (commented out) block of statements that have been added to the file in apache24.

Granted, fairly trivial, but still mildly annoying.  And will probably recur in the future, because diff/patch have no indicator for end-of-file.

Fix: 

Change the final chunk in apache24/files/patch-docs__conf__httpd.conf.in to this:

@@ -418,3 +418,4 @@
 #RequestHeader unset DNT env=bad_DNT
 #</IfModule>

+Include @rel_sysconfdir@/Includes/*.conf
How-To-Repeat: cd /usr/ports/www/apache24
make
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2013-08-09 01:11:21 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->apache

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Olli Hauer freebsd_committer freebsd_triage 2013-08-19 21:40:05 UTC 
State Changed
From-To: open->analyzed

Fix will be committed with the next version update 
since it triggers a rebuild on the package build cluster
Comment 3 Olli Hauer freebsd_committer freebsd_triage 2013-11-05 23:21:45 UTC 
State Changed
From-To: analyzed->closed

Committed in r 331790 
Thanks!