Bug 181272 - patch(1) can't deal with blanks in filenames, GNU patch can
Summary: patch(1) can't deal with blanks in filenames, GNU patch can
Status: Open
Alias: None
Product: Base System
Classification: Unclassified
Component: bin (show other bugs)
Version: 9.1-RELEASE
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-13 21:30 UTC by Matthias Andree
Modified: 2021-01-25 03:15 UTC (History)
1 user (show)

See Also:

Attachments
patch.txt (638 bytes, patch)
2013-08-18 07:17 UTC, David Carlier 		no flags Details | Diff
patch.txt (588 bytes, patch)
2013-08-19 19:17 UTC, David Carlier 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matthias Andree freebsd_committer freebsd_triage 2013-08-13 21:30:00 UTC 
FreeBSD 9.1-RELEASE's /usr/bin/patch cannot handle unified patches with
a blank in the filename, while GNU patch (from ports, installed as
gpatch) can.

Note that the filename on +++/--- lines extends from between the blank
after these three characters up to the next tab character.

Arguably this is nonstandard or unspecified behaviour, but then again
POSIX did not specify diff's -u format until very recently; and defers
to GNU diff.
Comment 1 Kyle Evans freebsd_committer freebsd_triage 2017-05-13 02:46:42 UTC 
I think this can safely be closed as "overcome by events."

Cannot seem to reproduce this with bspatch. 9.x is no longer supported and 10.3/11/-HEAD all default to bspatch with no option to install the older GNU patch as /usr/bin/patch.
Comment 2 Matthias Andree freebsd_committer freebsd_triage 2017-05-15 22:38:36 UTC 
if it is really overcome by events, and can now patch files with blanks in their names, feel free to close this PR.
Comment 3 Eitan Adler freebsd_committer freebsd_triage 2018-05-20 23:53:09 UTC 
For bugs matching the following conditions:
- Status == In Progress
- Assignee == "bugs@FreeBSD.org"
- Last Modified Year <= 2017

Do
- Set Status to "Open"