Bug 181730 - ports-mgmt/portlint: don't stop checks for COMMENT after first warning
Summary: ports-mgmt/portlint: don't stop checks for COMMENT after first warning
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Bryan Drewery
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-01 21:10 UTC by gerald
Modified: 2013-10-12 11:20 UTC (History)
0 users

See Also:


Attachments
file.diff (520 bytes, patch)
2013-09-01 21:10 UTC, gerald
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description gerald 2013-09-01 21:10:01 UTC
	Currently portlint stops checking for further issues once
	the first has been found for the COMMENT field in Makefile.

How-To-Repeat: 	Make COMMENT$of some test port read "a1234567890123456789012345678901234567890123456789012345678901234567890".
	Run portlint.
	See how there is no complaint about the length of the COMMENT.
Comment 1 Edwin Groothuis freebsd_committer 2013-09-01 21:10:14 UTC
Responsible Changed
From-To: freebsd-ports-bugs->marcus

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Bryan Drewery freebsd_committer 2013-10-12 11:11:34 UTC
Responsible Changed
From-To: marcus->bdrewery

I'll take it.
Comment 3 dfilter service freebsd_committer 2013-10-12 11:14:49 UTC
Author: bdrewery
Date: Sat Oct 12 10:14:41 2013
New Revision: 330124
URL: http://svnweb.freebsd.org/changeset/ports/330124

Log:
  - Update to 2.14.5
  
  Changes:
    * Fix recommending to replace USES=gmake with ${GMAKE} [1]
    * Ignore USES when recommending to replace direct commands [1]
    * Fix COMMENT check so it checks for length even if it
      is not formatted properly [2]
  
  PR:		ports/181359 [1]
  Submitted by:	Alan Hicks <ahicks@p-o.co.uk> [1]
  Reported by:	many
  PR:		ports/181730 [2]
  Submitted by:	gerald
  Approved by:	maintainer timeout (> 1 month)

Modified:
  head/ports-mgmt/portlint/Makefile
  head/ports-mgmt/portlint/src/portlint.pl

Modified: head/ports-mgmt/portlint/Makefile
==============================================================================
--- head/ports-mgmt/portlint/Makefile	Sat Oct 12 09:31:18 2013	(r330123)
+++ head/ports-mgmt/portlint/Makefile	Sat Oct 12 10:14:41 2013	(r330124)
@@ -2,7 +2,7 @@
 # $FreeBSD$
 
 PORTNAME=	portlint
-PORTVERSION=	2.14.4
+PORTVERSION=	2.14.5
 CATEGORIES=	ports-mgmt
 MASTER_SITES=	# none
 DISTFILES=	# none

Modified: head/ports-mgmt/portlint/src/portlint.pl
==============================================================================
--- head/ports-mgmt/portlint/src/portlint.pl	Sat Oct 12 09:31:18 2013	(r330123)
+++ head/ports-mgmt/portlint/src/portlint.pl	Sat Oct 12 10:14:41 2013	(r330124)
@@ -1157,11 +1157,11 @@ sub check_depends_syntax {
 					"USES[+]=gettext.");
 			}
 
-			# check USE_GMAKE
+			# check USES=gmake
 			if ($m{'dep'} =~ /^(gmake|\${GMAKE})$/) {
 				&perror("WARN", $file, -1, "dependency to $1 ".
 					"listed in $j. consider using ".
-					"USE_GMAKE.");
+					"USES[+]=gmake.");
 			}
 
 			# check USE_QT
@@ -1867,6 +1867,7 @@ ruby sed sh sort sysctl touch tr which x
 				&& $curline !~ /^NO_CDROM(.)?=[^\n]+$i/m
 				&& $curline !~ /^MAINTAINER(.)?=[^\n]+$i/m
 				&& $curline !~ /^CATEGORIES(.)?=[^\n]+$i/m
+				&& $curline !~ /^USES(.)?=[^\n]+$i/m
 				&& $curline !~ /^WX_COMPS(.)?=[^\n]+$i/m
 				&& $curline !~ /^\s*#.+$/m
 				&& $curline !~ /\-\-$i/m
@@ -2839,7 +2840,8 @@ MAINTAINER COMMENT
 	} else { # check for correctness
 		if (($makevar{COMMENT} !~ /^["\[0-9A-Z]/) || ($makevar{COMMENT} =~ m/\.$/)) { #"
 			&perror("WARN", $file, -1, "COMMENT should begin with a capital, and end without a period");
-		} elsif (length($makevar{COMMENT}) > 70) {
+		}
+		if (length($makevar{COMMENT}) > 70) {
 			&perror("WARN", $file, -1, "COMMENT exceeds 70 characters limit.");
 		}
 	}
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 4 Bryan Drewery freebsd_committer 2013-10-12 11:14:55 UTC
State Changed
From-To: open->closed

Committed, thanks