Bug 181799 - ports-mgmt/poudriere: [PATCH] allow in-line comments in ports-list
Summary: ports-mgmt/poudriere: [PATCH] allow in-line comments in ports-list
Status: In Progress
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Bryan Drewery
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2013-09-04 09:30 UTC by G. Paul Ziemba
Modified: 2022-10-17 12:40 UTC (History)
2 users (show)

See Also:

Attachments
file.diff (438 bytes, patch)
2013-09-04 09:30 UTC, G. Paul Ziemba 		no flags Details | Diff
patch-portlist-inline-comments.txt (1.02 KB, patch)
2013-09-14 03:09 UTC, G. Paul Ziemba 		no flags Details | Diff
patch against 3.2.6 (589 bytes, patch)
2018-10-31 00:36 UTC, G. Paul Ziemba 		no flags Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description G. Paul Ziemba 2013-09-04 09:30:00 UTC 
% poudriere version
3.0.4

The ports-list file for "bulk" seems to allow comments on lines by themselves, but does not allow comments on the same line as port names.

The attached patch allows a ports-list file to look like this:

    # A comment on a line by itself
    devel/patch    # a comment on the same line as a port name

Fix: Patch attached with submission follows:
How-To-Repeat: sudo poudriere bulk -w -p portstree -j 91s-amd64 -f list-of-ports
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2013-09-04 09:30:08 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->bapt

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 G. Paul Ziemba 2013-09-14 03:09:19 UTC 
Looks as if there is another place that parses the same port list file.
Here's an updated patch.

-- 
G. Paul Ziemba
FreeBSD unix:
 7:01PM  up 5 days, 16:30, 18 users, load averages: 0.98, 0.99, 0.99
Comment 3 Mark Linimon freebsd_committer freebsd_triage 2014-03-29 04:27:04 UTC 
Responsible Changed
From-To: bapt->bdrewery

Over to new maintainer.
Comment 4 Walter Schwarzenfeld freebsd_triage 2018-01-11 16:20:57 UTC 
Patch does not apply anymore.
No maintainer feedback till now.
Comment 5 Bryan Drewery freebsd_committer freebsd_triage 2018-01-24 19:38:02 UTC 
(In reply to w.schwarzenfeld from comment #4)
> Patch does not apply anymore.
> No maintainer feedback till now.

The box right above yours is maintainer feedback...
Comment 6 G. Paul Ziemba 2018-10-31 00:36:11 UTC 
Created attachment 198790 [details]
patch against 3.2.6
Comment 7 G. Paul Ziemba 2018-10-31 00:37:29 UTC 
Here is an updated patch I made earlier this year against poudriere 3.2.6. If anyone is ready to include my changes to the freebsd sources and finds that the patch no longer applies, I'd be happy to do a quick turn-around on a new patch.
Comment 8 Graham Perrin freebsd_committer freebsd_triage 2022-10-17 12:40:57 UTC 
Keyword: 

    patch
or  patch-ready

– in lieu of summary line prefix: 

    [patch]

* bulk change for the keyword
* summary lines may be edited manually (not in bulk). 

Keyword descriptions and search interface: 

    <https://bugs.freebsd.org/bugzilla/describekeywords.cgi>