Bug 181816 - [patch] lang/gcc42, lang/gcc44: remove USE_GCC=any
Summary: [patch] lang/gcc42, lang/gcc44: remove USE_GCC=any
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Gerald Pfeifer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-04 16:40 UTC by Tijl Coosemans
Modified: 2013-09-06 23:00 UTC (History)
0 users

See Also:


Attachments
gcc.patch (1.76 KB, patch)
2013-09-04 16:40 UTC, Tijl Coosemans
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tijl Coosemans freebsd_committer 2013-09-04 16:40:02 UTC
r305610 added USE_GCC=any to these ports but it seems the only problem
was that clang defaults to C99 which has different semantics for extern
inline functions.  The attached patch removes USE_GCC=any and adds
USE_CSTD=gnu89 for gcc42.  For gcc44 this is not possible because
libgfortran requires gnu99, so instead -fgnu89-inline was added to
CFLAGS.  This does not affect libgfortran because it only has static
inline functions.
The patch also contains some USES cleanups.
Comment 1 Edwin Groothuis freebsd_committer 2013-09-04 16:40:10 UTC
Responsible Changed
From-To: freebsd-ports-bugs->gerald

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 gerald 2013-09-04 18:10:10 UTC
Hi Tijl,

thanks for these submissions.  Just one question: why the 
PORTREVISION bumps?  Someone already having installed the 
port(s) should not be forced to rebuild/update, should they?

Can you confirm that you tested those in a clang-only, no GCC,
environment?

Gerald
Comment 3 dfilter service freebsd_committer 2013-09-06 22:51:34 UTC
Author: bapt
Date: Fri Sep  6 21:51:26 2013
New Revision: 326552
URL: http://svnweb.freebsd.org/changeset/ports/326552

Log:
  Fix build on head by removing USE_GCC=any and properly define USE_CSTD=gnu89 instead
  
  PR:		ports/181816
  Submitted by:	tijl
  Approved by:	gerald

Modified:
  head/lang/gcc42/Makefile

Modified: head/lang/gcc42/Makefile
==============================================================================
--- head/lang/gcc42/Makefile	Fri Sep  6 21:45:37 2013	(r326551)
+++ head/lang/gcc42/Makefile	Fri Sep  6 21:51:26 2013	(r326552)
@@ -23,11 +23,10 @@ VERSIONSTRING=	${PORTVERSION:C/([0-9]+\.
 SUFFIX=		${PORTVERSION:C/([0-9]+).([0-9]+).*/\1\2/}
 LATEST_LINK=	gcc${SUFFIX}${PKGNAMESUFFIX}
 NOT_FOR_ARCHS=	arm powerpc
-USES=		bison iconv
+USES=		bison gmake iconv perl5
 USE_BZIP2=	yes
-USE_GCC=	any
-USE_GMAKE=	yes
-USE_PERL5_BUILD=yes
+USE_CSTD=	gnu89
+USE_PERL5=	build
 
 PATCH_WRKSRC=	${SRCDIR}
 CONFIGURE_SCRIPT=	../${SRCDIR:S/${WRKDIR}\///}/configure
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 4 Baptiste Daroussin freebsd_committer 2013-09-06 22:53:31 UTC
State Changed
From-To: open->closed

Committed. Thanks!
Comment 5 dfilter service freebsd_committer 2013-09-06 22:54:36 UTC
Author: bapt
Date: Fri Sep  6 21:54:28 2013
New Revision: 326553
URL: http://svnweb.freebsd.org/changeset/ports/326553

Log:
  Fix build on head by removing USE_GCC=any, and adding  -fgnu89-inline to cflags
  (gfortran requires gnu99)
  
  PR:		ports/181816
  Submitted by:	tijl
  Approved by:	gerald

Modified:
  head/lang/gcc44/Makefile

Modified: head/lang/gcc44/Makefile
==============================================================================
--- head/lang/gcc44/Makefile	Fri Sep  6 21:51:26 2013	(r326552)
+++ head/lang/gcc44/Makefile	Fri Sep  6 21:54:28 2013	(r326553)
@@ -22,11 +22,9 @@ SUFFIX=		${PORTVERSION:C/([0-9]+).([0-9]
 LATEST_LINK=	gcc${SUFFIX}${PKGNAMESUFFIX}
 ONLY_FOR_ARCHS=	amd64 i386 sparc64
 USE_BINUTILS=	yes
-USES=		bison iconv
+USES=		bison gmake iconv perl5
 USE_BZIP2=	yes
-USE_GCC=	any
-USE_GMAKE=	yes
-USE_PERL5_BUILD=yes
+USE_PERL5=	build
 
 PATCH_WRKSRC=	${SRCDIR}
 CONFIGURE_SCRIPT=	../${SRCDIR:S/${WRKDIR}\///}/configure
@@ -44,7 +42,7 @@ WRKSRC=		${WRKDIR}/build
 TARGLIB=	${PREFIX}/lib/gcc${SUFFIX}
 LIBEXEC=	${PREFIX}/libexec/gcc${SUFFIX}
 GNU_CONFIGURE=	yes
-CFLAGS+=	-I${LOCALBASE}/include
+CFLAGS+=	-I${LOCALBASE}/include -fgnu89-inline
 CPPFLAGS+=	-I${LOCALBASE}/include
 CONFIGURE_ARGS+=--disable-bootstrap \
 		--disable-nls \
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"