Bug 182071 - [PATCH] databases/mysql56-server: Fix shebang on installed perl scripts
[PATCH] databases/mysql56-server: Fix shebang on installed perl scripts
Status: Closed FIXED
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s)
Latest
Any Any
: Normal Affects Only Me
Assigned To: Alex Dupre
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-09-13 23:50 UTC by freebsd
Modified: 2013-10-06 11:30 UTC (History)
0 users

See Also:


Attachments
file.diff (640 bytes, patch)
2013-09-13 23:50 UTC, freebsd
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description freebsd 2013-09-13 23:50:00 UTC
The MySQL 5.6 server (also MySQL 5.5 server) installs a number of perl-based scripts, but they are all hard-coded to /usr/bin/perl, an optional and discouraged location that may disappear in the future:

mysqldumpslow:1:#!/usr/bin/perl
mysql_setpermission:1:#!/usr/bin/perl
mysqlhotcopy:1:#!/usr/bin/perl
mysql_convert_table_format:1:#!/usr/bin/perl
mysql_zap:1:#!/usr/bin/perl
mysqld_multi:1:#!/usr/bin/perl
mysql_install_db:1:#!/usr/bin/perl
mysql_fix_extensions:1:#!/usr/bin/perl
mysql_secure_installation:1:#!/usr/bin/perl

These scripts need to have their shebang fixed.  Attached patch fixes it for MySQL 5.6.  To fix MySQL 5.5 is very similar.

Fix: Patch attached with submission follows:
Comment 1 Edwin Groothuis freebsd_committer 2013-09-13 23:50:08 UTC
Responsible Changed
From-To: freebsd-ports-bugs->ale

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter freebsd_committer 2013-10-06 11:25:48 UTC
Author: marino
Date: Sun Oct  6 10:25:40 2013
New Revision: 329549
URL: http://svnweb.freebsd.org/changeset/ports/329549

Log:
  databases/mysql5{5,6}-server: set shebangfix for perl
  
  PR:		ports/182071
  Approved by:	maintainer timeout

Modified:
  head/databases/mysql55-server/Makefile
  head/databases/mysql56-server/Makefile

Modified: head/databases/mysql55-server/Makefile
==============================================================================
--- head/databases/mysql55-server/Makefile	Sun Oct  6 10:14:04 2013	(r329548)
+++ head/databases/mysql55-server/Makefile	Sun Oct  6 10:25:40 2013	(r329549)
@@ -15,7 +15,7 @@ COMMENT?=	Multithreaded SQL database (se
 LICENSE=	GPLv2
 
 SLAVEDIRS=	databases/mysql55-client
-USES=		cmake
+USES=		cmake shebangfix
 NO_OPTIONS_SORT=yes
 
 OPTIONS_DEFINE=	SSL FASTMTX
@@ -42,6 +42,8 @@ CMAKE_ARGS+=	-DINSTALL_DOCDIR="share/doc
 		-DWITH_LIBEDIT=0 \
 		-DWITH_LIBWRAP=1
 
+SHEBANG_FILES=	scripts/*.pl* scripts/*.sh
+
 .ifdef USE_MYSQL
 .error You have `USE_MYSQL' variable defined either in environment or in make(1) arguments. Please undefine and try again.
 .endif

Modified: head/databases/mysql56-server/Makefile
==============================================================================
--- head/databases/mysql56-server/Makefile	Sun Oct  6 10:14:04 2013	(r329548)
+++ head/databases/mysql56-server/Makefile	Sun Oct  6 10:25:40 2013	(r329549)
@@ -13,7 +13,7 @@ MAINTAINER=	ale@FreeBSD.org
 COMMENT?=	Multithreaded SQL database (server)
 
 SLAVEDIRS=	databases/mysql56-client
-USES=		cmake
+USES=		cmake shebangfix
 
 CMAKE_ARGS+=	-DINSTALL_DOCDIR="share/doc/mysql" \
 		-DINSTALL_DOCREADMEDIR="share/doc/mysql" \
@@ -33,6 +33,8 @@ CMAKE_ARGS+=	-DINSTALL_DOCDIR="share/doc
 		-DWITH_EDITLINE=system \
 		-DWITH_LIBWRAP=1
 
+SHEBANG_FILES=	scripts/*.pl* scripts/*.sh
+
 .ifdef USE_MYSQL
 .error You have `USE_MYSQL' variable defined either in environment or in make(1) arguments. Please undefine and try again.
 .endif
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 3 John Marino freebsd_committer 2013-10-06 11:28:00 UTC
State Changed
From-To: open->closed

Committed. Thanks!