Bug 182159 - Fix ftp/wget to work with perl 5.18
Fix ftp/wget to work with perl 5.18
Status: Closed FIXED
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s)
Any Any
: Normal Affects Only Me
Assigned To: Vasil Dimov
Depends on:
  Show dependency treegraph
Reported: 2013-09-16 17:40 UTC by Jeremy Chadwick
Modified: 2013-10-24 15:30 UTC (History)
0 users

See Also:

file.diff (2.41 KB, patch)
2013-09-16 17:40 UTC, Jeremy Chadwick
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Chadwick 2013-09-16 17:40:01 UTC
	ftp/wget does not build when perl 5.18 is used on the system.
	The failure happens during the pod2man phase during build, and
	causes the build to bail out:

./texi2pod.pl -D VERSION="1.14" ./wget.texi wget.pod
/usr/local/bin/pod2man --center="GNU Wget" --release="GNU Wget 1.14" wget.pod > wget.1
wget.pod around line 2105: Expected text after =item, not a number
wget.pod around line 2110: Expected text after =item, not a number
wget.pod around line 2116: Expected text after =item, not a number
wget.pod around line 2121: Expected text after =item, not a number
wget.pod around line 2126: Expected text after =item, not a number
wget.pod around line 2131: Expected text after =item, not a number
wget.pod around line 2136: Expected text after =item, not a number
wget.pod around line 2141: Expected text after =item, not a number
POD document had syntax errors at /usr/local/bin/pod2man line 71.

	The official wget repo lacks a fix for this problem:


	...and I will be contacting them to have it fixed upstream and will
	follow up to this PR with a official bug number:


	In the meantime, roughly 4 months ago, some other folks came up
	with a workaround:


	However they seemed to miss fixing the IPv6 option (-6), so I've
	included that in the below.

Fix: Apply below patch (generated with "svn diff").  This will hold us
	over until I can get a proper fix from the official wget folks.

	A full replacement files/patch-doc__wget.texi will also be available
	at the below URL once I get a PR number from GNATS:


How-To-Repeat: 	cd /usr/ports/ftp/wget && make, on a system using perl 5.18.
Comment 1 Edwin Groothuis freebsd_committer 2013-09-16 17:40:10 UTC
Responsible Changed
From-To: freebsd-ports-bugs->vd

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 3 citrin 2013-10-24 14:46:55 UTC
Suggested path:

tested with current wget port and perl 5.18.1
Comment 4 dfilter freebsd_committer 2013-10-24 15:24:05 UTC
Author: vd
Date: Thu Oct 24 14:23:53 2013
New Revision: 331489
URL: http://svnweb.freebsd.org/changeset/ports/331489

  Fix compilation of ftp/wget when perl 5.18 is installed.
  Patch from upstream repo suggested by Anton Yuzhaninov <citrin@citrin.ru>.
  PR:		ports/182159
  Submitted by:   Jeremy Chadwick <jdc@koitsu.org>

  head/ftp/wget/files/patch-doc__texi2pod.pl   (contents, props changed)

Added: head/ftp/wget/files/patch-doc__texi2pod.pl
--- /dev/null	00:00:00 1970	(empty, because file is newly added)
+++ head/ftp/wget/files/patch-doc__texi2pod.pl	Thu Oct 24 14:23:53 2013	(r331489)
@@ -0,0 +1,11 @@
+--- doc/texi2pod.pl.orig	2013-10-24 16:59:55.000000000 +0300
++++ doc/texi2pod.pl	2013-10-24 17:01:23.000000000 +0300
+@@ -291,7 +291,7 @@
+ 	if (defined $1) {
+             my $thing = $1;
+             if ($ic =~ /\@asis/) {
+-                $_ = "\n=item $thing\n";
++                $_ = "\n=item C<$thing>\n";
+             } else {
+                 # Entity escapes prevent munging by the <> processing below.
+                 $_ = "\n=item $ic\&LT;$thing\&GT;\n";
svn-ports-all@freebsd.org mailing list
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 5 Vasil Dimov freebsd_committer 2013-10-24 15:24:22 UTC
State Changed
From-To: open->closed

Upstream patch added, thanks!