Bug 183008 - net-mgmt/ehnt: NO_STAGE removed, but it's not stage ready
Summary: net-mgmt/ehnt: NO_STAGE removed, but it's not stage ready
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Dmitry Morozovsky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-15 23:10 UTC by John Marino
Modified: 2013-10-16 14:10 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description John Marino freebsd_committer 2013-10-15 23:10:00 UTC
The maintainer removed "NO_STAGE=yes" with the commit message:
  Chase last void functions used as int.
  Enable STAGE support.
  Tested @:       ff, ref10-{i386,amd64}

The problem is that stage support wasn't actually added.  All that was done was remove NO_STAGE definition, which breaks the build.  The message says this was tested, but it apparently wasn't tested on a post-STAGE ports tree.

Fix: 

There are two options to unbreak the port

1) put "NO_STAGE=yes" back in the makefile
2) put the variable ${STAGEDIR} before all the PREFIX variables in the do-install make target.
Comment 1 Edwin Groothuis freebsd_committer 2013-10-15 23:10:08 UTC
Responsible Changed
From-To: freebsd-ports-bugs->marck

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer 2013-10-16 14:04:01 UTC
Author: marck (doc committer)
Date: Wed Oct 16 13:03:53 2013
New Revision: 330509
URL: http://svnweb.freebsd.org/changeset/ports/330509

Log:
  Actually do stage support
  
  PR:		183008
  Submitted by:	marino
  Pointy hat to:	marck

Modified:
  head/net-mgmt/ehnt/Makefile

Modified: head/net-mgmt/ehnt/Makefile
==============================================================================
--- head/net-mgmt/ehnt/Makefile	Wed Oct 16 13:00:35 2013	(r330508)
+++ head/net-mgmt/ehnt/Makefile	Wed Oct 16 13:03:53 2013	(r330509)
@@ -15,6 +15,7 @@ PLIST_FILES=	bin/ehnt etc/rc.d/ehntserv.
 PLIST_DIRS+=	share/ehnt
 
 PORTDOCS=	README
+STPREFIX=	${STAGEDIR}${PREFIX}
 
 MAN1=		ehnt.1
 MAN8=		ehntserv.8
@@ -23,16 +24,16 @@ post-extract:
 	${TOUCH} ${WRKSRC}/asnc.txt
 
 do-install:
-	${INSTALL_PROGRAM} ${WRKSRC}/ehnt ${PREFIX}/bin/
-	${INSTALL_PROGRAM} ${WRKSRC}/ehntserv ${PREFIX}/sbin/
-	${INSTALL_SCRIPT} ${FILESDIR}/ehntserv.sh.sample ${PREFIX}/etc/rc.d/
-	${INSTALL_MAN} ${WRKSRC}/ehnt.1 ${PREFIX}/man/man1/
-	${INSTALL_MAN} ${WRKSRC}/ehntserv.8 ${PREFIX}/man/man8/
-	${MKDIR} ${DATADIR}
-	${INSTALL_DATA} ${WRKSRC}/asnc.txt ${DATADIR}/
+	${INSTALL_PROGRAM} ${WRKSRC}/ehnt ${STPREFIX}/bin/
+	${INSTALL_PROGRAM} ${WRKSRC}/ehntserv ${STPREFIX}/sbin/
+	${INSTALL_SCRIPT} ${FILESDIR}/ehntserv.sh.sample ${STPREFIX}/etc/rc.d/
+	${INSTALL_MAN} ${WRKSRC}/ehnt.1 ${STPREFIX}/man/man1/
+	${INSTALL_MAN} ${WRKSRC}/ehntserv.8 ${STPREFIX}/man/man8/
+	${MKDIR} ${STAGEDIR}${DATADIR}
+	${INSTALL_DATA} ${WRKSRC}/asnc.txt ${STAGEDIR}${DATADIR}/
 .if !defined(NOPORTDOCS)
-	${MKDIR} ${DOCSDIR}
-	${INSTALL_DATA} ${WRKSRC}/${PORTDOCS} ${DOCSDIR}/
+	${MKDIR} ${STAGEDIR}${DOCSDIR}
+	${INSTALL_DATA} ${WRKSRC}/${PORTDOCS} ${STAGEDIR}${DOCSDIR}/
 .endif
 
 .include <bsd.port.mk>
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 3 Dmitry Morozovsky freebsd_committer 2013-10-16 14:05:19 UTC
State Changed
From-To: open->closed

Committed, thank you, and shame on too lazy me!