Bug 183278 - [PATCH] ports-mgmt/dialog4ports: fix WITH_DEBUG issue
[PATCH] ports-mgmt/dialog4ports: fix WITH_DEBUG issue
Status: Closed FIXED
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s)
Latest
Any Any
: Normal Affects Only Me
Assigned To: portmgr
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-10-24 18:50 UTC by Matthias Andree
Modified: 2013-10-24 21:55 UTC (History)
1 user (show)

See Also:


Attachments
dialog4ports-0.1.5_2.patch (1.06 KB, patch)
2013-10-24 18:50 UTC, Matthias Andree
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Matthias Andree freebsd_committer 2013-10-24 18:50:00 UTC
In its current shape, the port always installs with debug symbols. Fix
that, by only forwarding DEBUG_FLAGS if defined.

While at it, support staging.

Note that dialog4ports-static needs a similar fix, for reasons I don't
fully understand, however, INSTALL_PROGRAM always contains the -s for
STRIP.  Please look into that.

Port maintainer (rum1cro@yandex.ru) is cc'd.

Generated with FreeBSD Port Tools 0.99_8 (mode: change, diff: ports)
Comment 1 Edwin Groothuis freebsd_committer 2013-10-24 18:50:08 UTC
Responsible Changed
From-To: freebsd-ports-bugs->portmgr

portmgr@ wants this port PRs (via the GNATS Auto Assign Tool)
Comment 2 Edwin Groothuis freebsd_committer 2013-10-24 18:50:09 UTC
Maintainer of ports-mgmt/dialog4ports,

Please note that PR ports/183278 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/183278

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 3 Edwin Groothuis freebsd_committer 2013-10-24 18:50:10 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 4 rum1cro 2013-10-24 19:16:04 UTC
Approved.

-- 
With Best Regards,
Ilya A. Arkhipov
Comment 5 dfilter freebsd_committer 2013-10-24 19:18:45 UTC
Author: mandree
Date: Thu Oct 24 18:18:38 2013
New Revision: 331507
URL: http://svnweb.freebsd.org/changeset/ports/331507

Log:
  Permit port to be stripped if WITH_DEBUG is unset, by only forwarding
  DEBUG_FLAGS through MAKE_ARGS if the former is defined.
  
  While here, support staging.
  
  PR:		ports/183278
  Approved by:	Ilya A. Arkhipov (maintainer, on IRC)

Modified:
  head/ports-mgmt/dialog4ports/Makefile

Modified: head/ports-mgmt/dialog4ports/Makefile
==============================================================================
--- head/ports-mgmt/dialog4ports/Makefile	Thu Oct 24 17:44:00 2013	(r331506)
+++ head/ports-mgmt/dialog4ports/Makefile	Thu Oct 24 18:18:38 2013	(r331507)
@@ -3,7 +3,7 @@
 
 PORTNAME=	dialog4ports
 PORTVERSION=	0.1.5
-PORTREVISION?=	1
+PORTREVISION?=	2
 CATEGORIES=	ports-mgmt
 MASTER_SITES=	http://m1cro.tk/dialog4ports/ \
 		http://files.etoilebsd.net/dialog4ports/ \
@@ -23,14 +23,16 @@ MANCOMPRESSED=	yes
 MAKE_ENV+=	__MAKE_CONF=/dev/null SRCCONF=/dev/null
 
 .if !defined(D4P_SLAVE)
-MAN1=		${PORTNAME}.1
-PLIST_FILES=	bin/dialog4ports
+PLIST_FILES=	bin/dialog4ports man/man1/${PORTNAME}.1.gz
 .endif
 
-NO_STAGE=	yes
+NEED_ROOT=	yes
+
 .include <bsd.port.pre.mk>
 
+.if defined(DEBUG_FLAGS)
 MAKE_ARGS+=	DEBUG_FLAGS="${DEBUG_FLAGS}"
+.endif
 
 ## This is used by 'make config' via Tools/scripts/dialog4ports.sh
 ## Use caution in changing
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 6 Matthias Andree freebsd_committer 2013-10-24 21:55:27 UTC
State Changed
From-To: feedback->closed

closed, with portmgr's and maintainer's approval. Thanks.