Bug 183518 - sysutils/kiconvtool installs an rc(8) script that references the stage directory instead of PREFIX
Summary: sysutils/kiconvtool installs an rc(8) script that references the stage direct...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Dmitry Marakasov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-31 09:20 UTC by Kimmo Paasiala
Modified: 2013-10-31 19:50 UTC (History)
0 users

See Also:

Attachments
file.diff (1.28 KB, patch)
2013-10-31 09:20 UTC, Kimmo Paasiala 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kimmo Paasiala 2013-10-31 09:20:01 UTC 
sysutils/kiconvtool install a kiconv.sh rc(8) script that incorrectly uses the stage directory path to the kiconvtool binary instead of the correct ${PREFIX}/sbin/ path.

Fix: Apply the attached patch that removes the incorrect PREFIX assignment from the port Makefile and adds support for DESTDIR to the actual Makefile of the software.

Patch attached with submission follows:
How-To-Repeat: Install sysutils/kiconvtool and inspect the "command" variable in the ${PREFIX}/etc/rc.d/kiconv.sh script, it is set to the ${STAGEDIR}${PREFIX}/sbin instead of the correct ${PREFIX}/sbin.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2013-10-31 09:20:24 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->amdmi3

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer freebsd_triage 2013-10-31 19:46:33 UTC 
Author: amdmi3
Date: Thu Oct 31 19:46:24 2013
New Revision: 332281
URL: http://svnweb.freebsd.org/changeset/ports/332281

Log:
  - Update to 0.97
  - Fix rc.d script
  
  PR:		183518
  Submitted by:	Kimmo Paasiala <kpaasial@gmail.com>

Modified:
  head/sysutils/kiconvtool/Makefile
  head/sysutils/kiconvtool/distinfo

Modified: head/sysutils/kiconvtool/Makefile
==============================================================================
--- head/sysutils/kiconvtool/Makefile	Thu Oct 31 19:45:55 2013	(r332280)
+++ head/sysutils/kiconvtool/Makefile	Thu Oct 31 19:46:24 2013	(r332281)
@@ -2,7 +2,7 @@
 # $FreeBSD$
 
 PORTNAME=	kiconvtool
-PORTVERSION=	0.96
+PORTVERSION=	0.97
 CATEGORIES=	sysutils
 MASTER_SITES=	http://mirror.amdmi3.ru/distfiles/ \
 		LOCAL/amdmi3
@@ -12,8 +12,6 @@ COMMENT=	Tool to preload kernel iconv ch
 
 USES=		iconv	# used by libkiconv, actually
 
-MAKE_ARGS=	PREFIX="${STAGEDIR}${PREFIX}"
-
 PLIST_FILES=	sbin/${PORTNAME} etc/rc.d/kiconv \
 		man/man8/${PORTNAME}.8.gz
 

Modified: head/sysutils/kiconvtool/distinfo
==============================================================================
--- head/sysutils/kiconvtool/distinfo	Thu Oct 31 19:45:55 2013	(r332280)
+++ head/sysutils/kiconvtool/distinfo	Thu Oct 31 19:46:24 2013	(r332281)
@@ -1,2 +1,2 @@
-SHA256 (kiconvtool-0.96.tar.gz) = 6af936f81f8e3749fc5d0e094c6e7b5df57a95eec1b0df34d63cfd02783d3c64
-SIZE (kiconvtool-0.96.tar.gz) = 7119
+SHA256 (kiconvtool-0.97.tar.gz) = 84b5e869bdc9703f39ce252fd59fdee8c54a7aba9063ad1bae7fd1a9f3f7ff70
+SIZE (kiconvtool-0.97.tar.gz) = 7169
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 3 Dmitry Marakasov freebsd_committer freebsd_triage 2013-10-31 19:46:39 UTC 
State Changed
From-To: open->closed

Committed. Thanks!