Bug 183627 - games/wesnoth fails to compile
Summary: games/wesnoth fails to compile
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Alex Kozlov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-03 21:40 UTC by dog
Modified: 2013-11-24 13:10 UTC (History)
0 users

See Also:


Attachments
wesnoth.txt (1.69 KB, text/plain; charset=US-ASCII)
2013-11-09 16:29 UTC, Oleg Ginzburg
no flags Details
wesnoth.patch (1.68 KB, patch)
2013-11-14 00:43 UTC, rnejdl
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description dog 2013-11-03 21:40:00 UTC
Building process fails with the following error:

[ 87%] Building CXX object src/CMakeFiles/wesnoth.dir/formula_string_utils.cpp.o
[ 88%] Building CXX object src/CMakeFiles/wesnoth.dir/formula_tokenizer.cpp.o
[ 88%] Building CXX object src/CMakeFiles/wesnoth.dir/game_controller.cpp.o
[ 88%] Building CXX object src/CMakeFiles/wesnoth.dir/game_controller_abstract.cpp.o
[ 88%] Building CXX object src/CMakeFiles/wesnoth.dir/game_controller_new.cpp.o
[ 88%] Building CXX object src/CMakeFiles/wesnoth.dir/game_display.cpp.o
In file included from /usr/ports/games/wesnoth/work/wesnoth-1.10.7/src/game_display.cpp:23:
In file included from /usr/ports/games/wesnoth/work/wesnoth-1.10.7/src/game_display.hpp:28:
/usr/ports/games/wesnoth/work/wesnoth-1.10.7/src/chat_events.hpp:39:38: error: unknown type name 'time_t'
        virtual void add_chat_message(const time_t& time,
                                            ^
1 error generated.
*** Error code 1

Stop.
make[4]: stopped in /usr/ports/games/wesnoth/work/wesnoth-1.10.7
*** Error code 1

Stop.
make[3]: stopped in /usr/ports/games/wesnoth/work/wesnoth-1.10.7
*** Error code 1

Stop.
make[2]: stopped in /usr/ports/games/wesnoth/work/wesnoth-1.10.7
*** Error code 1

Stop.
make[1]: stopped in /usr/ports/games/wesnoth
*** Error code 1

Stop.
make: stopped in /usr/ports/games/wesnoth

Fix: 

I have no idea
How-To-Repeat: Build games/wesnoth port
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2013-11-03 21:40:07 UTC
Maintainer of games/wesnoth,

Please note that PR ports/183627 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/183627

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2013-11-03 21:40:08 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 rnejdl 2013-11-03 22:21:49 UTC
 

I'm aware of the issue as well but do not know how to resolve it either.
As far as I can tell, it will not compile using clang but I have been
unable to understand the new port structure to force it to use GCC4.6+
correctly (it simply ignores my USES line.) 

Rusty 

On 2013-11-03 21:40, Edwin Groothuis wrote: 

> Maintainer of games/wesnoth,
> 
> Please note that PR ports/183627 has just been submitted.
> 
> If it contains a patch for an upgrade, an enhancement or a bug fix
> you agree on, reply to this email stating that you approve the patch
> and a committer will take care of it.
> 
> The full text of the PR can be found at:
> http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/183627 [1]

 

Links:
------
[1] http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/183627
Comment 4 Alex Kozlov freebsd_committer freebsd_triage 2013-11-23 14:22:32 UTC
Responsible Changed
From-To: freebsd-ports-bugs->ak

I'll take it.
Comment 5 dfilter service freebsd_committer freebsd_triage 2013-11-24 13:05:33 UTC
Author: ak
Date: Sun Nov 24 13:05:25 2013
New Revision: 334722
URL: http://svnweb.freebsd.org/changeset/ports/334722

Log:
  - Fix build with clang [1]
  
  PR:	ports/183627
  Reported by:	Pavlo Greenberg <dog@virtual.org.ua>
  Submitted by:	Oleg Ginzburg <olevole@olevole.ru> [1]
  Approved by:	Rusty Nejdl <rnejdl@ringofsaturn.com> (maintainer)

Added:
  head/games/wesnoth/files/patch-src-chat_events.hpp   (contents, props changed)
  head/games/wesnoth/files/patch-src-server-metrics.hpp   (contents, props changed)
  head/games/wesnoth/files/patch-src-server-user_handler.cpp   (contents, props changed)

Added: head/games/wesnoth/files/patch-src-chat_events.hpp
==============================================================================
--- /dev/null	00:00:00 1970	(empty, because file is newly added)
+++ head/games/wesnoth/files/patch-src-chat_events.hpp	Sun Nov 24 13:05:25 2013	(r334722)
@@ -0,0 +1,10 @@
+--- src/chat_events.hpp.orig	2013-11-09 20:12:59.000000000 +0400
++++ src/chat_events.hpp	2013-11-09 20:13:07.000000000 +0400
+@@ -20,6 +20,7 @@
+ #include "global.hpp"
+ 
+ #include <string>
++#include <time.h>
+ 
+ namespace events {
+ 

Added: head/games/wesnoth/files/patch-src-server-metrics.hpp
==============================================================================
--- /dev/null	00:00:00 1970	(empty, because file is newly added)
+++ head/games/wesnoth/files/patch-src-server-metrics.hpp	Sun Nov 24 13:05:25 2013	(r334722)
@@ -0,0 +1,10 @@
+--- src/server/metrics.hpp.orig	2013-11-09 20:10:45.000000000 +0400
++++ src/server/metrics.hpp	2013-11-09 20:10:50.000000000 +0400
+@@ -27,6 +27,7 @@
+ #endif
+ 
+ #include "simple_wml.hpp"
++#include <time.h>
+ 
+ class metrics
+ {

Added: head/games/wesnoth/files/patch-src-server-user_handler.cpp
==============================================================================
--- /dev/null	00:00:00 1970	(empty, because file is newly added)
+++ head/games/wesnoth/files/patch-src-server-user_handler.cpp	Sun Nov 24 13:05:25 2013	(r334722)
@@ -0,0 +1,10 @@
+--- src/server/user_handler.cpp.orig	2013-11-09 20:09:08.000000000 +0400
++++ src/server/user_handler.cpp	2013-11-09 20:09:19.000000000 +0400
+@@ -18,6 +18,7 @@
+ #include "serialization/string_utils.hpp"
+ 
+ #include <ctime>
++#include <time.h>
+ 
+ bool user_handler::send_mail(const std::string& to_user,
+ 		const std::string& /*subject*/, const std::string& /*message*/) {
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 6 Alex Kozlov freebsd_committer freebsd_triage 2013-11-24 13:06:39 UTC
State Changed
From-To: feedback->closed

Committed. Thanks!