Bug 183668 - [panic] Panic when read unalign in ddb
Summary: [panic] Panic when read unalign in ddb
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: arm (show other bugs)
Version: Unspecified
Hardware: Any Any
: Normal Affects Only Me
Assignee: Ian Lepore
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-05 02:20 UTC by howard0su
Modified: 2014-07-25 23:52 UTC (History)
0 users

See Also:

Attachments
file.diff (362 bytes, patch)
2013-11-05 02:20 UTC, howard0su 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description howard0su 2013-11-05 02:20:00 UTC 
when read some memory in DDB unalign, the system will get reset. this is inconsistent with i386 behavior.

How-To-Repeat: Ctrl-Break, enter DDB
type 'dump thread 1'
Comment 1 dfilter service freebsd_committer freebsd_triage 2013-11-16 23:38:03 UTC 
Author: ian
Date: Sat Nov 16 23:37:56 2013
New Revision: 258240
URL: http://svnweb.freebsd.org/changeset/base/258240

Log:
  In the data abort handler, don't panic if kdb is available and says it
  handled the condition.
  
  PR:		arm/183668
  Submitted by:	Howard Su <howard0su@gmail.com>

Modified:
  head/sys/arm/arm/trap.c

Modified: head/sys/arm/arm/trap.c
==============================================================================
--- head/sys/arm/arm/trap.c	Sat Nov 16 21:58:58 2013	(r258239)
+++ head/sys/arm/arm/trap.c	Sat Nov 16 23:37:56 2013	(r258240)
@@ -528,7 +528,8 @@ dab_fatal(struct trapframe *tf, u_int fs
 
 #ifdef KDB
 	if (debugger_on_panic || kdb_active)
-		kdb_trap(fsr, 0, tf);
+		if (kdb_trap(fsr, 0, tf))
+			return (0);
 #endif
 	panic("Fatal abort");
 	/*NOTREACHED*/
_______________________________________________
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
Comment 2 Mark Linimon freebsd_committer freebsd_triage 2014-04-20 03:10:57 UTC 
State Changed
From-To: open->patched

over to committer as possible MFC candidate.
Comment 3 Mark Linimon freebsd_committer freebsd_triage 2014-04-20 03:10:57 UTC 
Responsible Changed
From-To: freebsd-arm->ian