Bug 183849 - [patch] security/py-pycryptopp: unbreak clang build
Summary: [patch] security/py-pycryptopp: unbreak clang build
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Wen Heping
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-10 21:40 UTC by Senno
Modified: 2015-03-13 15:58 UTC (History)
1 user (show)

See Also:


Attachments
patch.txt (10.18 KB, text/plain)
2013-11-10 21:40 UTC, Senno
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Senno 2013-11-10 21:40:00 UTC
setup.py assumes as(1) is used during build which isn't true. It's only
used if $CXX actually calls it and clang by default doesn't.

Equivalent issue existed in security/cryptopp and fixed in ports/154325.

How-To-Repeat: # patch-setup.py fixes the following error
$ make
[...]
clang -DNDEBUG -O2 -pipe -fPIC -I. -I/usr/local/include/python2.7 -c embeddedcryptopp/sosemanuk.cpp -o temp.freebsd-10-amd64-2.7/embeddedcryptopp/sosemanuk.o -w
embeddedcryptopp/sosemanuk.cpp:356:3: error: Unexpected token!
                ".intel_syntax noprefix;"
                ^
<inline asm>:1:40: note: instantiated into assembly here
        .intel_syntax noprefix;mov QWORD PTR [%r11+1*8], rdi;mov QWORD PTR [...
                                              ^
embeddedcryptopp/sosemanuk.cpp:356:3: error: unexpected token in argument list
                ".intel_syntax noprefix;"
                ^
[...]

# patch-299a99e fixes the following error
$ make
[...]
clang -DNDEBUG -O2 -pipe -fPIC -DCRYPTOPP_DISABLE_ASM=1 -I. -I/usr/local/include/python2.7 -c embeddedcryptopp/cryptlib.cpp -o temp.freebsd-10-amd64-2.7/embeddedcryptopp/cryptlib.o -w
embeddedcryptopp/cryptlib.cpp:33:26: error: default initialization of an object of
      const type 'const CryptoPP::NullNameValuePairs' requires a user-provided
      default constructor
const NullNameValuePairs g_nullNameValuePairs;
                         ^
1 error generated.
error: command 'cc' failed with exit status 1
*** Error code 1
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2013-11-10 21:40:08 UTC
Responsible Changed
From-To: freebsd-ports-bugs->wen

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 commit-hook freebsd_committer freebsd_triage 2015-03-13 15:57:30 UTC
A commit references this bug:

Author: robak
Date: Fri Mar 13 15:57:13 UTC 2015
New revision: 381218
URL: https://svnweb.freebsd.org/changeset/ports/381218

Log:
  security/py-pycryptopp: unbreak CLANG build

  - Drop GCC usage
  - Maintainer's timeout (wen@FreeBSD.org)

  PR:		183849
  Submitted by:	<senno@example.com>

Changes:
  head/security/py-pycryptopp/Makefile
  head/security/py-pycryptopp/files/patch-299a99e
  head/security/py-pycryptopp/files/patch-embeddedcryptopp_secblock.h
  head/security/py-pycryptopp/files/patch-setup.py
Comment 3 Bartek Rutkowski freebsd_committer freebsd_triage 2015-03-13 15:58:23 UTC
Committed, thanks for your work!