Bug 184325 - net/tcpdump and net/libpcap port upgrade
Summary: net/tcpdump and net/libpcap port upgrade
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Wesley Shields
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-27 12:50 UTC by Rodrigo OSORIO
Modified: 2013-12-29 20:50 UTC (History)
0 users

See Also:


Attachments
tcpdump-4.5.1.patch (1.61 KB, patch)
2013-11-27 12:50 UTC, Rodrigo OSORIO
no flags Details | Diff
file.diff (5.31 KB, patch)
2013-11-27 12:50 UTC, Rodrigo OSORIO
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Rodrigo OSORIO 2013-11-27 12:50:00 UTC
 	Update tcpdump from 4.4.0 to 4.5.1
	Update libpcap from 1.4.0 to 1.5.1

	Latest tcpdump releases commes with an new switch
	(-P) to filter the direction of the capture performed by
	tcpdump : in/out/inout.
	This feature is required at work for our testbed.

	The tcpdump compiles and works without error or warning after upgrade.

	I also remove NO_STAGE flag and fix install path, tcpdump and libpcat are stage ready !
Comment 1 Edwin Groothuis freebsd_committer 2013-11-27 12:50:09 UTC
Responsible Changed
From-To: freebsd-ports-bugs->wxs

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Rodrigo OSORIO 2013-11-27 13:01:10 UTC
Oups! I comment but forgot to remove NO_STAGE in libpcap.
Comment 3 dfilter service freebsd_committer 2013-12-29 20:44:28 UTC
Author: wxs
Date: Sun Dec 29 20:44:20 2013
New Revision: 338042
URL: http://svnweb.freebsd.org/changeset/ports/338042

Log:
  Make stage aware and turn on pcap_setdirection.
  
  PR:		ports/184325
  Submitted by:	Rodrigo Osorio <rodrigo@bebik.net>

Modified:
  head/net/tcpdump/Makefile

Modified: head/net/tcpdump/Makefile
==============================================================================
--- head/net/tcpdump/Makefile	Sun Dec 29 20:37:27 2013	(r338041)
+++ head/net/tcpdump/Makefile	Sun Dec 29 20:44:20 2013	(r338042)
@@ -29,8 +29,10 @@ SMI_DESC=	Allow MIBs to be loaded on the
 USER_DESC=	Drop privileges to nobody
 CHROOT_DESC=	Chroot to /var/run/tcpdump (set CHROOTDIR to change)
 
-NO_STAGE=	yes
 .include <bsd.port.options.mk>
+
+CONFIGURE_ARGS+=	--enable-pcap_setdirection --with-pcap_setdirection
+
 # The --without-crypto flag needs to be explicitly specified. The
 # configure script gets confused if you specify --with-crypto and
 # thinks this means you *don't* want crypto.
@@ -65,14 +67,14 @@ CONFIGURE_ARGS+=	--with-chroot=${CHROOTD
 
 .include <bsd.port.pre.mk>
 
-MAN1=		tcpdump.1
-PLIST_FILES=	sbin/tcpdump
+PLIST_FILES=	sbin/tcpdump \
+		man/man1/tcpdump.1.gz
 
 post-configure:
 	@${REINPLACE_CMD} -e "s,\./\.\./${LIBPCAP_FORCE_VER}/libpcap\.a,${LOCALBASE}/lib/libpcap.so.1," ${WRKSRC}/Makefile
 
 do-install:
-	${INSTALL_PROGRAM} ${WRKSRC}/tcpdump ${PREFIX}/sbin
-	${INSTALL_MAN} ${WRKSRC}/tcpdump.1 ${MAN1PREFIX}/man/man1
+	${INSTALL_PROGRAM} ${WRKSRC}/tcpdump ${STAGEDIR}/${PREFIX}/sbin
+	${INSTALL_MAN} ${WRKSRC}/tcpdump.1 ${STAGEDIR}/${MAN1PREFIX}/man/man1
 
 .include <bsd.port.post.mk>
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 4 Wesley Shields freebsd_committer 2013-12-29 20:47:03 UTC
State Changed
From-To: open->closed

Committed. Thanks!