Bug 184479 - [ patch ] devel/autoconf-wrapper: fix lost stdin
Summary: [ patch ] devel/autoconf-wrapper: fix lost stdin
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: autotools
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-03 20:20 UTC by Roman Bogorodskiy
Modified: 2013-12-09 19:20 UTC (History)
1 user (show)

See Also:


Attachments
autoconf-wrapper-stdin-fix.diff (764 bytes, patch)
2013-12-03 20:20 UTC, Roman Bogorodskiy
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Roman Bogorodskiy freebsd_committer 2013-12-03 20:20:00 UTC
	Autoconf tools could be used with pipe. For example,
        fresh autopoint from gettext uses autom4te this way:

         http://git.savannah.gnu.org/cgit/gettext.git/commit/gettext-tools/misc/autopoint.in?id=eea2dddde35037d25b3f240ab95836b6adeaf517

        As the wrapper currently eats stdin, autopoint doesn't work. It
        causes problems bootstrapping projects, e.g. I got this error
        with libvirt:

       (22:54) novel@dev:~/code/libvirt[master] %> ./autogen.sh
	I am going to run ./configure with no arguments - if you wish
	to pass any to it, please specify them on the ./autogen.sh command line.
	running bootstrap...
	./bootstrap: Bootstrapping from checked-out libvirt sources...
	./bootstrap: consider installing git-merge-changelog from gnulib
	./bootstrap: getting gnulib files...
	./bootstrap: autopoint --force
	autopoint: *** Missing version: please specify in configure.ac through a line 'AM_GNU_GETTEXT_VERSION(x.yy.zz)' the gettext version the package is using
	autopoint: *** Stop.
	Failed to bootstrap, please investigate.
	(22:54) novel@dev:~/code/libvirt[master] %>

	Attached patch fixes problem for me.
Comment 1 Edwin Groothuis freebsd_committer 2013-12-03 20:20:09 UTC
Responsible Changed
From-To: freebsd-ports-bugs->autotools

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer 2013-12-09 19:14:29 UTC
Author: kwm
Date: Mon Dec  9 19:14:22 2013
New Revision: 336016
URL: http://svnweb.freebsd.org/changeset/ports/336016

Log:
  Don't let the wrapper eat stdin, which breaks autopoint.
  
  PR:		ports/184479
  Submitted by:	novel@
  Approved by:	ade@ (autotools@ hat)

Modified:
  head/devel/autoconf-wrapper/Makefile
  head/devel/autoconf-wrapper/files/autotools-wrapper.sh

Modified: head/devel/autoconf-wrapper/Makefile
==============================================================================
--- head/devel/autoconf-wrapper/Makefile	Mon Dec  9 19:02:37 2013	(r336015)
+++ head/devel/autoconf-wrapper/Makefile	Mon Dec  9 19:14:22 2013	(r336016)
@@ -1,7 +1,7 @@
 # $FreeBSD$
 
 PORTNAME?=	autoconf-wrapper
-PORTVERSION=	20130530
+PORTVERSION=	20131203
 CATEGORIES=	devel
 MASTER_SITES=	# none
 DISTFILES=	# none

Modified: head/devel/autoconf-wrapper/files/autotools-wrapper.sh
==============================================================================
--- head/devel/autoconf-wrapper/files/autotools-wrapper.sh	Mon Dec  9 19:02:37 2013	(r336015)
+++ head/devel/autoconf-wrapper/files/autotools-wrapper.sh	Mon Dec  9 19:14:22 2013	(r336016)
@@ -31,6 +31,8 @@
 bindir=%%PREFIX%%/bin
 tool=$(basename $0)
 
+exec 4<&0
+
 error() {
 	echo "$@" 1>&2
 	exit 1
@@ -85,5 +87,6 @@ if [ -n "${AUTOTOOLS_DEBUG}" ] ; then
 	    "(${bindir}/${tool}-${selected_version})" 1>&2
 fi
 
+exec 0<&4 4<&-
 exec ${bindir}/${tool}-${selected_version} "$@"
 }
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 3 Koop Mast freebsd_committer 2013-12-09 19:14:39 UTC
State Changed
From-To: open->closed

Committed thanks!